chore: Bundle 2026-W9

[n8n-assistant]

Cherry-picked from n8n-private. Original PR: https://github.com/n8n-io/n8n-private/pull/39

[cubic-dev-ai]

4 issues found across 50 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/testing/playwright/tests/e2e/api/binary-data-xss.spec.ts">

<violation number="1" location="packages/testing/playwright/tests/e2e/api/binary-data-xss.spec.ts:100">
P1: Do not swallow all `page.goto` errors here; it can make the XSS test pass even when the attack URL was never actually loaded.</violation>
</file>

<file name="packages/@n8n/nodes-langchain/nodes/agents/Agent/agents/SqlAgent/execute.ts">

<violation number="1" location="packages/@n8n/nodes-langchain/nodes/agents/Agent/agents/SqlAgent/execute.ts:47">
P1: String-literal stripping uses backslash escaping (`\'`) but standard SQL (PostgreSQL, SQLite) escapes quotes by doubling (`''`). An LLM-generated query like `SELECT 'foo\' FROM t; DELETE FROM users; SELECT 'x'` bypasses the check: the regex consumes `DELETE` as part of a "string" while PostgreSQL executes it as live SQL.

Consider also stripping SQL-standard doubled-quote strings, e.g., by replacing `''` inside quotes first, or by using a pattern that accounts for both escape styles.</violation>
</file>

<file name="packages/core/src/execution-engine/node-execution-context/utils/request-helpers/axios-utils.ts">

<violation number="1" location="packages/core/src/execution-engine/node-execution-context/utils/request-helpers/axios-utils.ts:24">
P2: Use `ExpressionError` instead of `ApplicationError` for this user-facing validation failure.

(Based on your team's feedback about using ExpressionError instead of deprecated ApplicationError for user-facing expression errors.) [FEEDBACK_USED]</violation>
</file>

<file name="packages/cli/src/public-api/v1/shared/services/pagination.service.ts">

<violation number="1" location="packages/cli/src/public-api/v1/shared/services/pagination.service.ts:53">
P2: Handle `limit <= 0` in `paginateArray`; otherwise the generated next cursor can repeat the same offset forever (e.g. `limit=0`).</violation>
</file>

Architecture diagram

sequenceDiagram
    participant Client as External Client / UI
    participant API as API / Express Controllers
    participant Guard as NEW: Security Guards / Middleware
    participant Service as MCP / Workflow / Binary Service
    participant Engine as Execution Engine (Nodes)
    participant DB as Database / Repositories

    Note over Client, DB: MCP OAuth Registration & Authorization
    Client->>API: POST /mcp-oauth/register
    API->>Guard: NEW: mcpEnabledGuard()
    Guard-->>API: Continue if MCP enabled
    API->>Service: McpOAuthService.registerClient()
    Service->>Service: NEW: validateClientRegistration() (URI limits)
    Service->>DB: Insert OAuth Client
    Service->>DB: NEW: enforceClientLimit() (Max 200)
    alt Client Limit Reached
        DB-->>Service: Count > Limit
        Service->>DB: Rollback (Delete client)
        Service-->>API: Error 403
    else Success
        Service-->>API: 201 Created
    end
    API-->>Client: Return Client Credentials

    Note over Client, DB: Binary Data Access (Security fix)
    Client->>API: GET /rest/binary-data (action=download)
    API->>Service: BinaryDataController.getBinaryData()
    Service->>API: CHANGED: Set CSP & Content-Disposition
    Note right of API: NEW: apply getWebhookSandboxCSP()<br/>CHANGED: Enforce 'attachment' if no filename
    API-->>Client: Stream file with security headers

    Note over Client, DB: Node Execution (SQL & Domain Security)
    Engine->>Engine: NEW: detectBlockedSqlKeyword()
    alt SQL Agent Flow
        Engine->>Engine: NEW: Wrap 'query-sql' tool in DynamicTool
        Engine->>Engine: Check for INSERT/UPDATE/DELETE/DROP
        alt Blocked Keyword Found
            Engine-->>Client: Error: SQL operation not allowed
        end
    end

    Engine->>Engine: CHANGED: getAllowedDomains(credential)
    alt HTTP Request Flow
        Engine->>Engine: NEW: throwIfDomainNotAllowed()
        opt Redirect
            Engine->>Engine: NEW: beforeRedirect() check domain
        end
    end

    Note over Client, DB: Workflow Management (Project Scoping)
    Client->>API: Import / Create Workflow
    API->>Service: WorkflowCreationService.replaceInvalidCredentials()
    Service->>DB: CHANGED: findByNameAndTypeInProject(name, type, projectId)
    Note right of DB: Prevent cross-project credential leakage<br/>during workflow resolution.
    DB-->>Service: Return project-scoped credential
    Service-->>API: Workflow ready
    API-->>Client: Success

    Note over Engine, DB: LDAP & SQL Sandbox Injection Prevention
    Engine->>Engine: NEW: Ldap.escapeValue() for searchText/attributes
    Engine->>Engine: NEW: Block fetch/XHR in AlaSql SQL Sandbox

Loading

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[codecov]

Bundle Report

Bundle size has no change ✅

Affected Assets, Files, and Routes:

view changes for bundle: editor-ui-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
assets/worker-*.js	2.93MB	2.95MB	21924.63% ⚠️
assets/worker-*.js	-2.93MB	13.37kB	-99.55%
assets/expression-*.js	11 bytes	220 bytes	5.26% ⚠️
assets/expression-*.js	-11 bytes	209 bytes	-5.0%

[codspeed]

Merging this PR will not alter performance

✅ 32 untouched benchmarks
⏩ 7 skipped benchmarks¹

---

_{Comparing private-20260325-072643 (78817a2) with master (bf856cd)²}

Footnotes

1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

2. No successful run was found on master (fc0f071) during the generation of this report, so bf856cd was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[codecov]

Codecov Report

❌ Patch coverage is 77.17391% with 42 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...es-base/nodes/HttpRequest/V1/HttpRequestV1.node.ts	30.00%	9 Missing and 5 partials ⚠️
...hain/nodes/agents/Agent/agents/SqlAgent/execute.ts	46.66%	8 Missing ⚠️
packages/cli/src/modules/mcp/mcp-oauth-service.ts	68.42%	6 Missing ⚠️
...es-base/nodes/HttpRequest/V3/HttpRequestV3.node.ts	61.53%	5 Missing ⚠️
...es-base/nodes/HttpRequest/V2/HttpRequestV2.node.ts	63.63%	4 Missing ⚠️
...@n8n/db/src/repositories/credentials.repository.ts	0.00%	2 Missing ⚠️
...s-langchain/nodes/trigger/ChatTrigger/templates.ts	66.66%	0 Missing and 1 partial ⚠️
...c/modules/data-table/data-table-rows.repository.ts	0.00%	1 Missing ⚠️
...s/nodes-base/nodes/HttpRequest/GenericFunctions.ts	95.00%	0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

[n8n-assistant]

Successfully created backport PR for release-candidate/2.14.x:

• chore: Bundle 2026-W9 (backport to release-candidate/2.14.x) #27536

[n8n-assistant]

Created backport PR for release-candidate/2.13.x:

• chore: Bundle 2026-W9 (backport to release-candidate/2.13.x) #27537 with remaining conflicts!

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-27532-to-release-candidate/2.13.x
git worktree add --checkout .worktree/backport-27532-to-release-candidate/2.13.x backport-27532-to-release-candidate/2.13.x
cd .worktree/backport-27532-to-release-candidate/2.13.x
git reset --hard HEAD^
git cherry-pick -x 2d9a2ec76e180b54e8091e31b1e0638c909abd99
git push --force-with-lease

[n8n-assistant]

Created backport PR for 1.x:

• chore: Bundle 2026-W9 (backport to 1.x) #27538 with remaining conflicts!

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-27532-to-1.x
git worktree add --checkout .worktree/backport-27532-to-1.x backport-27532-to-1.x
cd .worktree/backport-27532-to-1.x
git reset --hard HEAD^
git cherry-pick -x 2d9a2ec76e180b54e8091e31b1e0638c909abd99
git push --force-with-lease

[n8n-assistant]

Got released with n8n@2.15.0