refactor(editor): Migrate execution and logs composables to workflowDocumentStore (no-changelog)

[alexgrozav]

Summary

Migrate 4 composables from workflowsStore/workflowState to the new workflowDocumentStore: useExecutionDebugging, useLogsExecutionData, useLogsSelection, and useChatState. All composables use the inject pattern since they're called from within the WorkflowLayout component tree. Update 3 test files to mock the injected store and wire it in test fixtures.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/CAT-2519

Review / Merge checklist

• PR title and summary are descriptive. (conventions)
• Docs updated or follow-up ticket created.
• Tests included.
• PR Labeled with Backport to Beta, Backport to Stable, or Backport to v1 (if the PR is an urgent fix that needs to be backported)

[codecov]

Bundle Report

Changes will increase total bundle size by 16.03kB (0.04%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
editor-ui-esm	42.81MB	16.03kB (0.04%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: editor-ui-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
assets/constants-*.js	-96 bytes	2.9MB	-0.0%
assets/DataTableDetailsView-*.js	295 bytes	1.59MB	0.02%
assets/ParameterInputList-*.js	94 bytes	1.47MB	0.01%
assets/index-*.js	-1.28kB	1.18MB	-0.11%
assets/users.store-*.js	64 bytes	1.07MB	0.01%
assets/index-*.css	20 bytes	799.17kB	0.0%
assets/_MapCache-*.js	1.14kB	588.59kB	0.19%
assets/src-*.css	-12 bytes	481.02kB	-0.0%
assets/usePostMessageHandler-*.js	370 bytes	125.99kB	0.29%
assets/WorkflowLayout-*.js	299 bytes	124.5kB	0.24%
assets/chat.store-*.js	396 bytes	58.8kB	0.68%
assets/ChatView-*.js	31 bytes	57.51kB	0.05%
assets/upload-*.js (New)	43.2kB	43.2kB	100.0% 🚀
assets/useLogsTreeExpand-*.js	279 bytes	38.87kB	0.72%
assets/SettingsUsersView-*.js	-527 bytes	31.56kB	-1.64%
assets/ChatLayout-*.js	20 bytes	21.27kB	0.09%
assets/AddDataTableModal-*.js	-42.74kB	20.29kB	-67.81%
assets/DataTableActions-*.js	10.75kB	17.58kB	157.23% ⚠️
assets/dataTable.store-*.js	231 bytes	9.22kB	2.57%
assets/DataTableActions-*.css	3.74kB	6.43kB	138.93% ⚠️
assets/useExecutionDebugging-*.js	68 bytes	5.25kB	1.31%
assets/SignupView-*.js	-509 bytes	3.88kB	-11.61%
assets/chatHubPanel.store-*.js	211 bytes	1.8kB	13.26% ⚠️
assets/expression-*.js	-17 bytes	209 bytes	-7.52%
assets/expression-*.js	11 bytes	220 bytes	5.26% ⚠️
assets/expression-*.js	6 bytes	226 bytes	2.73%

Files in assets/usePostMessageHandler-*.js:

• ./src/features/execution/logs/composables/useLogsSelection.ts → Total Size: 3.24kB

• ./src/features/execution/logs/composables/useChatState.ts → Total Size: 6.87kB

Files in assets/useLogsTreeExpand-*.js:

• ./src/features/execution/logs/composables/useLogsExecutionData.ts → Total Size: 4.26kB

Files in assets/useExecutionDebugging-*.js:

• ./src/features/execution/executions/composables/useExecutionDebugging.ts → Total Size: 4.78kB

[codecov]

Codecov Report

❌ Patch coverage is 76.31579% with 9 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...on/executions/composables/useExecutionDebugging.ts	50.00%	5 Missing ⚠️
...res/execution/logs/composables/useLogsSelection.ts	57.14%	2 Missing and 1 partial ⚠️
...execution/logs/composables/useLogsExecutionData.ts	91.66%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

[cubic-dev-ai]

3 issues found across 7 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/frontend/editor-ui/src/features/execution/logs/components/LogsPanel.test.ts">

<violation number="1" location="packages/frontend/editor-ui/src/features/execution/logs/components/LogsPanel.test.ts:107">
P2: The injected `workflowDocumentStore` is created for a hard-coded ID and never populated with the test workflow nodes, so the migrated composables read an empty document store.

According to linked Linear issue CAT-2519, the injected store needs to be wired into the test fixtures for this migration.</violation>
</file>

<file name="packages/frontend/editor-ui/src/features/execution/logs/composables/useChatState.test.ts">

<violation number="1" location="packages/frontend/editor-ui/src/features/execution/logs/composables/useChatState.test.ts:175">
P2: This fixture still relies on `workflowsStore` for node setup, so the suite does not actually test the migrated `workflowDocumentStore` path.

According to linked Linear issue CAT-2519, this test should exercise the document-store access pattern directly.</violation>
</file>

<file name="packages/frontend/editor-ui/src/features/execution/executions/composables/useExecutionDebugging.ts">

<violation number="1" location="packages/frontend/editor-ui/src/features/execution/executions/composables/useExecutionDebugging.ts:33">
P1: Don't inject `workflowDocumentStore` here; `useExecutionDebugging()` is also constructed from `WorkflowLayout` before that store is provided, so the debug-import path ends up with a permanent `null` store and skips restoring node state.</violation>
</file>

Architecture diagram

sequenceDiagram
    participant UI as Workflow UI / Canvas
    participant Layout as WorkflowLayout (Provider)
    participant Debug as useExecutionDebugging
    participant Logs as useLogsSelection / useChatState
    participant DocStore as workflowDocumentStore
    participant WFStore as workflowsStore
    participant State as workflowState

    Note over Layout,DocStore: NEW: Store Injection Pattern
    Layout->>DocStore: Initialize store for specific workflow ID
    Layout-->>Debug: NEW: Inject workflowDocumentStore
    Layout-->>Logs: NEW: Inject workflowDocumentStore

    rect rgb(23, 37, 84)
    Note over UI,State: Execution Debugging Flow (Restoring Data)
    UI->>Debug: applyExecutionData(executionId)
    Debug->>WFStore: getExecution(executionId)
    WFStore-->>Debug: Execution results

    Debug->>DocStore: CHANGED: getNodes()
    DocStore-->>Debug: Current UI nodes

    Debug->>DocStore: NEW: Access pinData
    alt Node already pinned
        Debug->>DocStore: NEW: unpinNodeData(nodeName)
    end

    Debug->>DocStore: NEW: resetAllNodesIssues()
    Debug->>State: setWorkflowExecutionData(execution)
    
    loop For each root node in execution
        Debug->>DocStore: NEW: pinNodeData(nodeName, data)
    end
    end

    rect rgb(5, 46, 22)
    Note over Logs,DocStore: Logs & Chat State Synchronization
    Logs->>DocStore: NEW: Access allNodes
    Note right of Logs: Filters for Chat/Trigger nodes
    
    UI->>Logs: Select node on Canvas
    Logs->>DocStore: NEW: Lookup in nodesByName
    DocStore-->>Logs: node metadata
    Logs->>Logs: Sync selection state
    end

Loading

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P2: The injected workflowDocumentStore is created for a hard-coded ID and never populated with the test workflow nodes, so the migrated composables read an empty document store.

According to linked Linear issue CAT-2519, the injected store needs to be wired into the test fixtures for this migration.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/frontend/editor-ui/src/features/execution/logs/components/LogsPanel.test.ts, line 107:

<comment>The injected `workflowDocumentStore` is created for a hard-coded ID and never populated with the test workflow nodes, so the migrated composables read an empty document store.

According to linked Linear issue CAT-2519, the injected store needs to be wired into the test fixtures for this migration.</comment>

<file context>
@@ -100,6 +104,9 @@ describe('LogsPanel', () => {
 					[ChatOptionsSymbol as symbol]: {},
 					[WorkflowStateKey as symbol]: workflowState,
 					[WorkflowIdKey as unknown as string]: computed(() => 'test-workflow-id'),
+					[WorkflowDocumentStoreKey as symbol]: shallowRef(
+						useWorkflowDocumentStore(createWorkflowDocumentId('test-workflow-id')),
+					),
</file context>

[cubic-dev-ai]

P2: This fixture still relies on workflowsStore for node setup, so the suite does not actually test the migrated workflowDocumentStore path.

According to linked Linear issue CAT-2519, this test should exercise the document-store access pattern directly.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/frontend/editor-ui/src/features/execution/logs/composables/useChatState.test.ts, line 175:

<comment>This fixture still relies on `workflowsStore` for node setup, so the suite does not actually test the migrated `workflowDocumentStore` path.

According to linked Linear issue CAT-2519, this test should exercise the document-store access pattern directly.</comment>

<file context>
@@ -159,6 +171,9 @@ describe('useChatState', () => {
 		setActivePinia(pinia);
 		workflowsStore = useWorkflowsStore();
+		vi.mocked(injectWorkflowDocumentStore).mockReturnValue(
+			shallowRef(useWorkflowDocumentStore(createWorkflowDocumentId(workflowsStore.workflowId))),
+		);
 		logsStore = useLogsStore();
</file context>

[n8n-assistant]

Got released with n8n@2.14.0