fix(core): Use class-validator with XSS check for survey answers #10490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomi
requested changes
Aug 21, 2024
n8n-assistant
bot
added
core
tomi
reviewed
Aug 21, 2024
ivov
added
the
release/backport
ivov
changed the title
tomi
approved these changes
Aug 21, 2024
|
Thank you 🙏🏻 |
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
|
✅ All Cypress E2E specs passed |
Merged
|
Got released with |
MiloradFilipovic
added a commit
that referenced
this pull request
Aug 22, 2024
* master: 🚀 Release 1.56.0 (#10502) fix(editor): Sending 'Assistant session started event' to posthog (no-changelog) (#10500) fix(core): Use class-validator with XSS check for survey answers (#10490) fix(editor): Stop telemetry from triggering when initializing workflow in new canvas (no-changelog) (#10492) fix(AI Transform Node): Remove prompt as it's already set in ASK AI endpoint (no-changelog) (#10496) fix(editor): Prevent unloading when changes are pending in new canvas (no-changelog) (#10474) feat(core): Upgrade axios to address CVE-2024-39338 (no-changelog) (#10494)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
xsslib in the XSS validator sanitizes string arrays into strings, causing the equality check to fail:[ 'cloud-infrastructure-orchestration', 'ci-cd', 'reporting' ]cloud-infrastructure-orchestration,ci-cd,reportingThis PR adjusts the equality check for arrays.
Follow-up to: https://linear.app/n8n/issue/PAY-1868