fix(editor): Prevent unloading when changes are pending in new canvas (no-changelog) #10474
Conversation
n8n-assistant
bot
added
n8n team
| */ | ||
|
|
||
| function onBeforeUnload(e: BeforeUnloadEvent) { | ||
| if (isDemoRoute.value || window.preventNodeViewBeforeUnload) { |
There was a problem hiding this comment.
What's this preventNodeViewBeforeUnload flag? I don't see it being set anywhere in the code
There was a problem hiding this comment.
it's used in the e2e tests to skip this prompt
| @@ -1410,6 +1427,10 @@ onBeforeMount(() => { | |||
| } | |||
| }); | |||
|
|
|||
| onActivated(() => { | |||
| window.addEventListener('beforeunload', onBeforeUnload); | |||
There was a problem hiding this comment.
Shouldn't we remove this listener also when this component is unmounted?
| * Unload | ||
| */ | ||
|
|
||
| function onBeforeUnload(e: BeforeUnloadEvent) { |
There was a problem hiding this comment.
Could we extract this stuff into a useBeforeUnload composable, instead of duplicating this code?
…the-warning-when-trying-to-close-the-tab-and-there
| onUnload() { | ||
| // This will fire if users decides to leave the page after prompted | ||
| // Clear the interval to prevent the notification from being sent | ||
| clearTimeout(this.unloadTimeout); |
There was a problem hiding this comment.
This timeout is no longer cleared. Is that intentional?
There was a problem hiding this comment.
It's cleared but not set anywhere in the code. I assume it's leftover code from another past change.
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
|
✅ All Cypress E2E specs passed |
alexgrozav
deleted the
n8n-7587-weve-lost-the-warning-when-trying-to-close-the-tab-and-there
branch
|
Got released with |
* master: 🚀 Release 1.56.0 (#10502) fix(editor): Sending 'Assistant session started event' to posthog (no-changelog) (#10500) fix(core): Use class-validator with XSS check for survey answers (#10490) fix(editor): Stop telemetry from triggering when initializing workflow in new canvas (no-changelog) (#10492) fix(AI Transform Node): Remove prompt as it's already set in ASK AI endpoint (no-changelog) (#10496) fix(editor): Prevent unloading when changes are pending in new canvas (no-changelog) (#10474) feat(core): Upgrade axios to address CVE-2024-39338 (no-changelog) (#10494)
Summary
Screen.Recording.2024-08-19.at.14.42.22.mov
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/N8N-7587/weve-lost-the-warning-when-trying-to-close-the-tab-and-there-are
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)