fix(FTP Node): Fix issue with creating folders on rename #9340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
|
Any chance this getting approved for the next release? Very much so looking forward to this fix. :) |
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
gh/9296
|
| Run status |
|
| Run duration | 04m 24s |
| Commit |
|
| Committer | Jonathan Bennetts |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
459
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
Merged
|
Got released with |
riascho
pushed a commit
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were not using the
createDirectoriesoption on FTP rename for folders that didn't exist, This PR will try to create a directory if this option is set and if the server returns a 451 error code. We may need to add more error codes in the future depending on FTP server implementation, This was tested with pure-ftpd.Related tickets and issues
https://linear.app/n8n/issue/NODE-1946/the-system-cannot-find-the-path-specified-error-in-ftp-node
Closes #9296