Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FTP Node): Fix issue with creating folders on rename #9340

Merged
merged 3 commits into from
Dec 10, 2024
Merged

fix(FTP Node): Fix issue with creating folders on rename #9340

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef7239b
fix(FTP Node): Fix issue with creating folders on rename
Joffcom May 8, 2024
7263a77
Merge branch 'master' of github.com:n8n-io/n8n into gh/9296
Joffcom Nov 5, 2024
84fc2f9
Added 550 to handle IIS rename failure
Joffcom Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions packages/nodes-base/nodes/Ftp/Ftp.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,10 +752,20 @@ export class Ftp implements INodeType {

if (operation === 'rename') {
const oldPath = this.getNodeParameter('oldPath', i) as string;

const newPath = this.getNodeParameter('newPath', i) as string;
const options = this.getNodeParameter('options', i);

await ftp!.rename(oldPath, newPath);
try {
await ftp!.rename(oldPath, newPath);
} catch (error) {
if ([451, 550].includes(error.code) && options.createDirectories) {
const dirPath = newPath.replace(basename(newPath), '');
await ftp!.mkdir(dirPath, true);
await ftp!.rename(oldPath, newPath);
} else {
throw new NodeApiError(this.getNode(), error as JsonObject);
}
}
const executionData = this.helpers.constructExecutionMetaData(
[{ json: { success: true } }],
{ itemData: { item: i } },
Expand Down
Loading