Skip to content

Commit

Permalink
fix(FTP Node): Fix issue with creating folders on rename (#9340)
Browse files Browse the repository at this point in the history
  • Loading branch information
Joffcom authored and riascho committed Jan 14, 2025
1 parent ada5500 commit 4f8c265
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions packages/nodes-base/nodes/Ftp/Ftp.node.ts
Original file line number Diff line number Diff line change
Expand Up @@ -752,10 +752,20 @@ export class Ftp implements INodeType {

if (operation === 'rename') {
const oldPath = this.getNodeParameter('oldPath', i) as string;

const newPath = this.getNodeParameter('newPath', i) as string;
const options = this.getNodeParameter('options', i);

await ftp!.rename(oldPath, newPath);
try {
await ftp!.rename(oldPath, newPath);
} catch (error) {
if ([451, 550].includes(error.code) && options.createDirectories) {
const dirPath = newPath.replace(basename(newPath), '');
await ftp!.mkdir(dirPath, true);
await ftp!.rename(oldPath, newPath);
} else {
throw new NodeApiError(this.getNode(), error as JsonObject);
}
}
const executionData = this.helpers.constructExecutionMetaData(
[{ json: { success: true } }],
{ itemData: { item: i } },
Expand Down

0 comments on commit 4f8c265

Please sign in to comment.