[Forwardport] chore: use random_int() in some places#3
Open
mzeis wants to merge 83 commits into2.3-developfrom
Open
[Forwardport] chore: use random_int() in some places#3mzeis wants to merge 83 commits into2.3-developfrom
mzeis wants to merge 83 commits into2.3-developfrom
Conversation
…tual product (gift card)
…override customer group_id and store_id
…lying an extra cent to the discount amount for
…override customer group_id and store_id
…tual product (gift card)
…lying an extra cent to the discount amount for
…e="allowfullscreen">false</var> for mobile device don't work in product view page gallery Change the type of config variables of values "true" and "false" to type boolean, instead of string.
…late to handle boolean config Variables Due to changes implemented in the resolution to magento#12285, boolean configuration variables are now properly typed booleans, instead of the strings "true" and "false". Without this fix applied, config vals that were true were being output in the gallery template javascript as : 1 and values that were false were being output as : This causes javascript errors for any item that is set to false.
… Gallery Template to handle boolean config Variables magento#15022 - Merge Pull Request magento#15022 from gwharton/magento2:2.3-develop-15020 - Merged commits: 1. 163d4cc
Fixed Travis Build Problems
\Magento\Catalog\Block\Product\ListProduct::getAddToCartPostParams incorrectly defined a string return type when in fact it's an array
…n Block class to ensure extensibility of the class. not doing so causes invalid template errors after extending the block class via preference
- Merge Pull Request magento#15083 from adrian-martinez-interactiv4/magento2:2.3-develop-PR-port-15023 - Merged commits: 1. c68b1af 2. f48135b 3. 32bd463
…15069 - Merge Pull Request magento#15069 from adrian-martinez-interactiv4/magento2:2.3-develop-PR-port-14609 - Merged commits: 1. 6771f36 2. 79b74b6 3. 4276a24
… to array magento#15073 - Merge Pull Request magento#15073 from adrian-martinez-interactiv4/magento2:2.3-develop-PR-port-14876 - Merged commits: 1. a132f54
…gento#15075 - Merge Pull Request magento#15075 from adrian-martinez-interactiv4/magento2:2.3-develop-PR-port-14896 - Merged commits: 1. 361d576
- Merge Pull Request magento#15078 from adrian-martinez-interactiv4/magento2:2.3-develop-PR-port-14928 - Merged commits: 1. 435650b
…stead of using template/path i… magento#15081 - Merge Pull Request magento#15081 from adrian-martinez-interactiv4/magento2:2.3-develop-PR-port-14946 - Merged commits: 1. 44a1f2b
…stead of using template/path i… magento#15081
…yPal Express checkout magento#15050
Accepted Public Pull Requests: - magento#15051: [Forwardport] Add statement to 'beforeSave' method to allow app:config:import (by @rogyar) - magento#15034: [Forwardport] fix: set message-success in setup if we already have the latest version (by @DanielRuf) - magento#15022: [2.3-develop] [ForwardPort] Port of magento#15020 Update Gallery Template to handle boolean config Variables (by @gwharton) - magento#15021: [2.3-develop] [ForwardPort] Port of magento#12285 The option <var name="allowfullscreen">false</var> for mobile device don't work in product view page gallery (by @gwharton) - magento#15081: [Forwardport] use "Module_Name::template/path" format instead of using template/path i� (by @adrian-martinez-interactiv4) - magento#15078: [Forwardport] Removed extra close tag (by @adrian-martinez-interactiv4) - magento#15075: [Forwardport] Removed extra spaces from language file (by @adrian-martinez-interactiv4) - magento#15073: [Forwardport] Changed return type of addToCartPostParams to array (by @adrian-martinez-interactiv4) - magento#15069: [Forwardport] Code cleanup, add more visibility (by @adrian-martinez-interactiv4) - magento#15083: [Forwardport] Fixed typos in .less files (by @adrian-martinez-interactiv4) - magento#15050: [Forwardport] Duplicate Order Confirmation Emails for PayPal Express checkout (by @rogyar) Fixed GitHub Issues: - magento#12285: The option <var name="allowfullscreen">false</var> for mobile device don't work in product view page gallery (reported by @novakivskiy) has been fixed in magento#15022 by @gwharton in 2.3-develop branch Related commits: 1. 163d4cc - magento#15009: [2.2.4] Gallery theme variables being ignored (reported by @gwharton) has been fixed in magento#15022 by @gwharton in 2.3-develop branch Related commits: 1. 163d4cc - magento#12285: The option <var name="allowfullscreen">false</var> for mobile device don't work in product view page gallery (reported by @novakivskiy) has been fixed in magento#15021 by @gwharton in 2.3-develop branch Related commits: 1. 435b165 2. 4113f26 3. c0b9e8f 4. 05b1512 5. 2701a4f
Fixed issues: - MAGETWO-90144 [Forwardport] Fixed amount discount for whole cart applying an extra cent to the discount amount for - MAGETWO-90310 [Magento Cloud] - PayPal pop up does not work with virtual product (gift card) - MAGETWO-90313 Import existing customer with only three columns will override customer group_id and store_id
Fixed issues: - DEVOPS-232 Static Testing in Jenkins
mzeis
force-pushed
the
2.3-develop-PR-port-15017
branch
from
1b03fd5 to
435d241
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#15017
Description
This PR is for evaluating the possible increased security for generating random numbers in some modules.
Contribution checklist