Skip to content

Fix: Handle duplicate style keys after trimming in ParseStyle #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mysticmind merged 1 commit into from
Feb 24, 2026
Merged

Fix: Handle duplicate style keys after trimming in ParseStyle #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...eRowWithDuplicateStyleKeysAfterTrimming_ThenConvertWithoutException.verified.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
| Header |
| --- |
| Data |
7 changes: 7 additions & 0 deletions src/ReverseMarkdown.Test/ConverterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1971,5 +1971,12 @@ public Task WhenTable_WithCaptionContainingNewlines_ThenHandleNewlines()
var html = $"<table><caption>Multi{Environment.NewLine}Line{Environment.NewLine}Caption</caption><tr><th>Col</th></tr><tr><td>Data</td></tr></table>";
return CheckConversion(html);
}

[Fact]
public Task WhenTableRowWithDuplicateStyleKeysAfterTrimming_ThenConvertWithoutException()
{
var html = "<table><tr><th style=\"font-size:12px; font-family:Work Sans; font-size:14px; font-size:14px\">Header</th></tr><tr><td>Data</td></tr></table>";
return CheckConversion(html);
}
}
}
5 changes: 3 additions & 2 deletions src/ReverseMarkdown/Helpers/StringUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ public static Dictionary<string, string> ParseStyle(string? style)
var styles = style!.Split(';');
return styles.Select(styleItem => styleItem.Split(':'))
.Where(styleParts => styleParts.Length == 2)
.DistinctBy(styleParts => styleParts[0])
.ToDictionary(styleParts => styleParts[0].Trim(), styleParts => styleParts[1].Trim(), StringComparer.OrdinalIgnoreCase);
.Select(styleParts => new[] { styleParts[0].Trim(), styleParts[1].Trim() })
.DistinctBy(styleParts => styleParts[0], StringComparer.OrdinalIgnoreCase)
.ToDictionary(styleParts => styleParts[0], styleParts => styleParts[1], StringComparer.OrdinalIgnoreCase);
}
}