Fix: Handle duplicate style keys after trimming in ParseStyle#416
Merged
mysticmind merged 1 commit intoFeb 24, 2026
Merged
Conversation
med-khalil
force-pushed
the
fix/parse-style-duplicate-keys
branch
from
February 11, 2026 15:18
6d45573 to
e03593e
Compare
med-khalil
marked this pull request as draft
February 11, 2026 15:19
med-khalil
force-pushed
the
fix/parse-style-duplicate-keys
branch
from
February 11, 2026 15:24
e03593e to
8b09324
Compare
Fixes a bug where style attributes with duplicate keys (after trimming spaces) would throw a duplicate key exception. Changes: Trim key-value pairs before DistinctBy to prevent false duplicates, add case-insensitive comparer to DistinctBy for proper deduplication, add converter test to verify the fix
med-khalil
force-pushed
the
fix/parse-style-duplicate-keys
branch
from
February 11, 2026 15:27
8b09324 to
0e4116c
Compare
med-khalil
marked this pull request as ready for review
February 11, 2026 15:27
Owner
|
Thanks for the PR @med-khalil |
This was referenced Feb 24, 2026
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where style attributes with duplicate keys (after trimming spaces) would throw a duplicate key exception.
Changes: Trim key-value pairs before DistinctBy to prevent false duplicates, add case-insensitive comparer to DistinctBy for proper deduplication, add converter test to verify the fix