Repository navigation
fix(ci): ignore remapped stale Codex findings - #28
Conversation
|
@codex review |
|
@coderabbitai review |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe review gate now accepts only Codex inline findings whose ChangesCodex review gate
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex-gate approve c006744 5230104575 |
|
To use Codex here, create an environment for this repo. |
|
@coderabbitai review |
✅ Action performedReview finished.
|
Summary
commit_id/original_commit_idsplitWhy
GitHub may update an inline review comment's
commit_idwhen its position still maps onto the latest diff, whileoriginal_commit_idretains the immutable commit that Codex actually reviewed. The deterministic gate currently treats either field as a current-head finding, so a resolved stale finding can reject an otherwise valid exact-head clean receipt.This is a small bootstrap PR because
issue_commentsecurity workflows run from the default branch. Landing the gate owner first lets the release-lineage repair PR qualify through the corrected trusted workflow without bypassing the required status.Validation
bun test scripts/codex-review-gate.test.ts- 9 pass, 0 failbun teston the identical patch in PR fix(release): allow lineage label reconciliation #27 - 533 pass, 3 explicit manual/hosted skips, 0 fail, 2357 expectationsactionlint .github/workflows/codex-review-gate.ymlgit diff --checkGenerated with Compound Engineering
Summary by CodeRabbit