Skip to content

fix(ci): ignore remapped stale Codex findings - #28

Merged
myagentdojo merged 1 commit into
mainfrom
codex/fix-codex-gate-remapped-findings
Aug 9, 2026
Merged

myagentdojo merged 1 commit into
mainfrom
codex/fix-codex-gate-remapped-findings

Conversation

@myagentdojo

@myagentdojo myagentdojo commented Aug 9, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • count a Codex inline finding against the commit where it was originally authored
  • ignore resolved stale findings that GitHub remaps onto the latest diff
  • add a regression fixture for the observed commit_id / original_commit_id split

Why

GitHub may update an inline review comment's commit_id when its position still maps onto the latest diff, while original_commit_id retains the immutable commit that Codex actually reviewed. The deterministic gate currently treats either field as a current-head finding, so a resolved stale finding can reject an otherwise valid exact-head clean receipt.

This is a small bootstrap PR because issue_comment security workflows run from the default branch. Landing the gate owner first lets the release-lineage repair PR qualify through the corrected trusted workflow without bypassing the required status.

Validation

  • bun test scripts/codex-review-gate.test.ts - 9 pass, 0 fail
  • bun test on the identical patch in PR fix(release): allow lineage label reconciliation #27 - 533 pass, 3 explicit manual/hosted skips, 0 fail, 2357 expectations
  • actionlint .github/workflows/codex-review-gate.yml
  • git diff --check

Generated with Compound Engineering

Summary by CodeRabbit

  • Bug Fixes
    • Updated review approval checks to recognize only inline comments tied to the current pull request revision.
    • Prevented outdated remapped inline findings from blocking approval.

@myagentdojo

Copy link
Copy Markdown
Owner Author

@codex review

@myagentdojo

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 9, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 31f5ce23-78db-4340-831b-09f3d649bd7a

📥 Commits

Reviewing files that changed from the base of the PR and between c9067f6 and c006744.

📒 Files selected for processing (2)
  • .github/workflows/codex-review-gate.yml
  • scripts/codex-review-gate.test.ts

📝 Walkthrough

Walkthrough

The review gate now accepts only Codex inline findings whose original_commit_id matches the current pull-request head. Tests cover remapped inline findings with stale original commits.

Changes

Codex review gate

Layer / File(s) Summary
Current-head finding filter and test coverage
.github/workflows/codex-review-gate.yml, scripts/codex-review-gate.test.ts
The workflow matches findings only by the current head’s original_commit_id. Tests add the remapped-inline surface, mock stale original commits, and verify approval succeeds.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the CI change to ignore remapped stale Codex findings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-codex-gate-remapped-findings

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@myagentdojo
myagentdojo temporarily deployed to hosted-canary-qualification August 9, 2026 06:11 — with GitHub Actions Inactive
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: c006744ae6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@myagentdojo

Copy link
Copy Markdown
Owner Author

@codex-gate approve c006744 5230104575

@chatgpt-codex-connector

Copy link
Copy Markdown

To use Codex here, create an environment for this repo.

@myagentdojo

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 9, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@myagentdojo
myagentdojo merged commit fbdd5d8 into main Aug 9, 2026
20 checks passed
@myagentdojo
myagentdojo deleted the codex/fix-codex-gate-remapped-findings branch August 9, 2026 06:48
This was referenced Aug 9, 2026

This branch was previously deployed

1 inactive deployment
hosted-canary-qualification — c006744a Deployed Aug 9, 2026 by myagentdojo via Qualify immutable hosted candidates #100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants