Merge recent gen ai changes to v2_10_0 branch#29
Merged
mxiamxia merged 2 commits intomxiamxia:v2_10_0_patchfrom Jan 7, 2025
yiyuan-he:merge-parser-to-v2_10_0
Merged
Merge recent gen ai changes to v2_10_0 branch#29mxiamxia merged 2 commits intomxiamxia:v2_10_0_patchfrom yiyuan-he:merge-parser-to-v2_10_0
mxiamxia merged 2 commits intomxiamxia:v2_10_0_patchfrom
yiyuan-he:merge-parser-to-v2_10_0
Conversation
yiyuan-he
changed the title
yiyuan-he
commented
Dec 20, 2024
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| package io.opentelemetry.instrumentation.awssdk.v2_2.internal; |
Author
There was a problem hiding this comment.
FYI. The file structure is slightly different for release series 2.x in the Java v2 instrumentation. Overall, the implementation is unchanged.
Before:
package io.opentelemetry.instrumentation.awssdk.v2_2;
After:
package io.opentelemetry.instrumentation.awssdk.v2_2.internal;
mxiamxia
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Merging these changes into our new
v2_10_0_patchbranch for feature parity withv1_33_6_patch.The main changes included are:
Previously we validated merged these changes to
v1_33_6_patchbranch:Test plan:
Ran unit tests for Java v1 and v2 instrumentation.
Ran contract tests.
Verified the correct span data is being generate by sample app in v1 and v2 instrumentation.