update genai system attribute name to align with upstream#26
Merged
mxiamxia merged 1 commit intomxiamxia:v1_33_6_patchfrom Dec 17, 2024
yiyuan-he:update-genai-system
Merged
update genai system attribute name to align with upstream#26mxiamxia merged 1 commit intomxiamxia:v1_33_6_patchfrom yiyuan-he:update-genai-system
mxiamxia merged 1 commit intomxiamxia:v1_33_6_patchfrom
yiyuan-he:update-genai-system
Conversation
mxiamxia
approved these changes
Dec 17, 2024
This was referenced Dec 17, 2024
mxiamxia
pushed a commit
to aws-observability/aws-otel-java-instrumentation
that referenced
this pull request
Jan 7, 2025
*Description of changes:* Small changes in our contract test assertions to align with recent Gen AI changes in upstream patch. Relevant changes from upstream patch: - mxiamxia/opentelemetry-java-instrumentation#26 - mxiamxia/opentelemetry-java-instrumentation#27 *Test plan:* Ran the updated contract tests.  By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Updating
gen_ai.systemattribute key to better align with upstream Otel conventions.Context: open-telemetry/semantic-conventions#1574 (comment)
Test plan:
Ran updated unit tests and new attribute value in spans from sample apps.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.