Skip to content

Place symbols over rests in layering, for ease of dragging #29816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 11, 2025
Merged

Place symbols over rests in layering, for ease of dragging #29816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc5957b
Move symbols over rests in type enumerating for layering
RMRattray Sep 11, 2025
43cccb9
Move symbols over rests in array per comment in types.h
RMRattray Sep 11, 2025
7e104c6
Move symbol after dead slapped as well as rests
RMRattray Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/engraving/types/types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,14 +89,14 @@ enum class ElementType : unsigned char {
STEM, // list STEM before NOTE: notes in TAB might 'break' stems
HOOK, // and this requires stems to be drawn before notes
NOTE, // elements from CLEF to TIMESIG need to be in the order
SYMBOL, // in which they appear in a measure
CLEF,
CLEF, // in which they appear in a measure
KEYSIG,
AMBITUS,
TIMESIG,
REST,
MMREST,
DEAD_SLAPPED,
SYMBOL,
BREATH,
MEASURE_REPEAT,
TIE,
Expand Down
6 changes: 3 additions & 3 deletions src/engraving/types/typesconv.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,9 +196,6 @@ static const std::array ELEMENT_TYPES {
Item{ ElementType::SCORE, "Score",
TranslatableString("engraving", "score(s)", nullptr, 1),
TranslatableString("engraving", "Score(s)", nullptr, 1) },
Item{ ElementType::SYMBOL, "Symbol",
TranslatableString("engraving", "symbol(s)", nullptr, 1),
TranslatableString("engraving", "Symbol(s)", nullptr, 1) },
Item{ ElementType::TEXT, "Text",
TranslatableString("engraving", "text", nullptr, 1),
TranslatableString("engraving", "Text", nullptr, 1) },
Expand Down Expand Up @@ -274,6 +271,9 @@ static const std::array ELEMENT_TYPES {
Item{ ElementType::DEAD_SLAPPED, "DeadSlapped",
TranslatableString("engraving", "dead slapped", nullptr, 1),
TranslatableString("engraving", "Dead slapped", nullptr, 1) },
Item{ ElementType::SYMBOL, "Symbol",
TranslatableString("engraving", "symbol(s)", nullptr, 1),
TranslatableString("engraving", "Symbol(s)", nullptr, 1) },
Item{ ElementType::BREATH, "Breath",
TranslatableString("engraving", "breath(s)", nullptr, 1),
TranslatableString("engraving", "Breath(s)", nullptr, 1) },
Expand Down
Loading