Skip to content

Conversation

RMRattray
Copy link
Contributor

Resolves: #21230

In response to the addressed issue, it was found that obscure symbols were placed over notes, but not over rests, according to the layering in types.h; according to a glance at the file around the time of the pull request, it did used to be the case; this re-ordering places symbols above rests as well, though they do tend not to overlap anyhow. The ordering of the elements in the array in typeconv.cpp was changed in the same manner, owing to a comment in types.h requesting that they be synced; other pre-existing discrepancies in the ordering were allowed to remain for the sake of minimal changes.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

Copy link
Member

@cbjeukendrup cbjeukendrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zacjansheski
Copy link
Contributor

Tested on MacOS 15, Windows 11, Ubuntu 22.04.3. Approved
#21230 FIXED

@cbjeukendrup cbjeukendrup merged commit a81c46e into musescore:master Sep 11, 2025
12 of 13 checks passed
@its-not-nice
Copy link
Contributor

@RMRattray Thanks very much for this - this exact issue was driving me crazy only yesterday!

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 12, 2025
@cbjeukendrup cbjeukendrup mentioned this pull request Sep 12, 2025
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 12, 2025
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 12, 2025
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Obscure palette elements have their default placement behind the note they're applied to
4 participants