Big alloc fallback #474
Merged
Big alloc fallback #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We keep a memory base, but much smaller ~73M. It is a concatenation of RAM, ROM, DD_ROM, RSP_MEM and PIF_MEM. A helper function translate a N64 physical address into a suitable pointer in memory_base.
The big 512M allocation is tried first and if it fails, try the smaller one. We encode the selected mode (full or compressed) using the LSB of the base_mem pointer. This should allow systems with enough virtual memory to use the full mem base mode, while still allowing other systems to use the compressed mem base mode.
|
Tested both modes on Linux, no issues |
|
I have confirmation from a user with the issue that this now works correctly! I can also confirm that it works correctly on Android devices that don't have the issue. This should be merged soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another try at the memory allocation failure encountered in some Android devices. As this is likely due to a shortage of virtual memory, in this PR we provide a fallback mechanism which requires much less memory.