-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some devices are failing CoreStartup with M64ERR_NO_MEMORY #467
Comments
I think the problem here is that either for their device overcommitting is disabled or that their malloc implementation doesn't use an anonymous mmap internally. I think replacing the malloc/free with mmap/munmap (VirtualAlloc/VirtualFree for Win32) will fix this. Will do a PR when I get back home. |
I replaced malloc and free with
It seems to run, but I haven't gotten results from devices with the issue yet. I will report back when I do. |
The above didn't work for them, it instead crashed when accessing the memory. I'm having them try your pull request next. |
Ok, I'll let you know when I can. |
@bsmiles32 It seems like recent change is breaking many Android devices. Specifically this commit:
143cfa7#diff-fa9734f1550e974c80b15a8a6fed3ad7
A lot of devices are failing with
M64ERR_NO_MEMORY
on CoreStartup.Is there any way to fallback to the old behavior if we are unable to allocate that much RAM?
So far this error has been limited to Samsung devices.
The text was updated successfully, but these errors were encountered: