Skip to content

⬆️👽 Update mqt-core to its latest version #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
burgholzer wants to merge 4 commits into from
Closed

⬆️👽 Update mqt-core to its latest version #539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9bba65b
⬆️👽 update to latest mqt-core version and adapt to changes
burgholzer Jan 21, 2025
8b82f49
🩹 do not bother setting up ancillary and garbage when there is no qub…
burgholzer Jan 21, 2025
a97212f
🎨 use dedicated name for ancillary register added to circuits
burgholzer Jan 21, 2025
a49cf1f
🔥✅ remove long-running test circuits from unittests
burgholzer Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmake/ExternalDependencies.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ endif()
# cmake-format: off
set(MQT_CORE_VERSION 2.7.1
CACHE STRING "MQT Core version")
set(MQT_CORE_REV "5c3cb8edf0f43663a8edc7ae77c753926b466802"
set(MQT_CORE_REV "cefedf2ec154498b591ba0c0d25ccde5e2bb0fb5"
CACHE STRING "MQT Core identifier (tag, branch or commit hash)")
set(MQT_CORE_REPO_OWNER "cda-tum"
CACHE STRING "MQT Core repository owner (change when using a fork)")
Expand Down
6 changes: 5 additions & 1 deletion src/EquivalenceCheckingManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,10 @@ void EquivalenceCheckingManager::setupAncillariesAndGarbage() {
const auto qubitDifference =
largerCircuit.getNqubits() - smallerCircuit.getNqubits();

if (qubitDifference == 0) {
return;
}

std::vector<std::pair<qc::Qubit, std::optional<qc::Qubit>>> removed{};
removed.reserve(qubitDifference);

Expand All @@ -203,7 +207,7 @@ void EquivalenceCheckingManager::setupAncillariesAndGarbage() {
}

// add appropriate ancillary register to smaller circuit
smallerCircuit.addAncillaryRegister(qubitDifference);
smallerCircuit.addAncillaryRegister(qubitDifference, "anc_qcec");

// reverse iterate over the removed qubits and add them back into the larger
// circuit as ancillary
Expand Down
4 changes: 2 additions & 2 deletions test/legacy/test_compilationflow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ INSTANTIATE_TEST_SUITE_P(
testing::Values("dk27_225", "pcler8_248", "5xp1_194", "alu1_198",
"mlp4_245", "dk17_224", "add6_196", "C7552_205", "cu_219",
"example2_231", "c2_181", "rd73_312", "cm150a_210",
"cm163a_213", "c2_182", "sym9_317", "mod5adder_306",
"rd84_313", "cm151a_211", "apla_203"),
"cm163a_213", "c2_182", "sym9_317", "cm151a_211",
"apla_203"),
[](const testing::TestParamInfo<CompilationFlowTest::ParamType>& inf) {
auto s = inf.param;
std::replace(s.begin(), s.end(), '-', '_');
Expand Down
6 changes: 3 additions & 3 deletions test/test_dynamic_circuits.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,8 +235,8 @@ class DynamicCircuitTestBV : public testing::TestWithParam<qc::Qubit> {
bv = qc::createBernsteinVazirani(bitwidth);

const auto expected = bv.getName().substr(3);
dbv =
qc::createIterativeBernsteinVazirani(qc::BitString(expected), bitwidth);
dbv = qc::createIterativeBernsteinVazirani(qc::BVBitString(expected),
bitwidth);

std::cout << "Hidden bitstring: " << expected << " (" << bitwidth
<< " qubits)\n";
Expand Down Expand Up @@ -312,7 +312,7 @@ TEST_P(DynamicCircuitTestQFT, UnitaryEquivalence) {
}

TEST(GeneralDynamicCircuitTest, DynamicCircuit) {
constexpr auto s = qc::BitString(15U);
constexpr auto s = qc::BVBitString(15U);
const auto bv = qc::createBernsteinVazirani(s);
const auto dbv = qc::createIterativeBernsteinVazirani(s);

Expand Down
Loading