Skip to content

Commit

Permalink
Enable RBAC by default
Browse files Browse the repository at this point in the history
  • Loading branch information
mumoshu committed Aug 30, 2017
1 parent c50663f commit cde5e3a
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 9 deletions.
2 changes: 1 addition & 1 deletion core/controlplane/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ func NewDefaultCluster() *Cluster {
},
Plugins: Plugins{
Rbac: Rbac{
Enabled: false,
Enabled: true,
},
},
Oidc: model.Oidc{
Expand Down
20 changes: 12 additions & 8 deletions core/controlplane/config/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -830,6 +830,18 @@ experimental:
},
{
conf: `
experimental:
nodeAuthorizer:
enabled: true
tlsBootstrap:
enabled: true
`,
nodeAuthorizer: NodeAuthorizer{
Enabled: true,
},
},
{
conf: `
experimental:
nodeAuthorizer:
enabled: true
Expand Down Expand Up @@ -862,14 +874,6 @@ experimental:
`,
`
# RBAC must be enabled as well
experimental:
nodeAuthorizer:
enabled: true
tlsBootstrap:
enabled: true
`,
`
# RBAC must be enabled as well
experimental:
nodeAuthorizer:
enabled: true
Expand Down
5 changes: 5 additions & 0 deletions test/integration/maincluster_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,11 @@ func TestMainClusterConfig(t *testing.T) {
Enabled: false,
DrainTimeout: 5,
},
Plugins: controlplane_config.Plugins{
Rbac: controlplane_config.Rbac{
Enabled: true,
},
},
}

actual := c.Experimental
Expand Down

0 comments on commit cde5e3a

Please sign in to comment.