Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Enabling RBAC by default #655

Closed
mumoshu opened this issue May 16, 2017 · 5 comments
Closed

Enabling RBAC by default #655

mumoshu opened this issue May 16, 2017 · 5 comments
Milestone

Comments

@mumoshu
Copy link
Contributor

mumoshu commented May 16, 2017

Thanks to huge efforts from multiple kube-aws contributors @gianrubio @danielfm @camilb, kube-aws supports RBAC, which is still disabled by default.

On the other hand, people seem to start noticing the default behavior of kubernetes/kube-aws "
deploy the token with the cluster-admin privilege to every pod"
is a security hole/a major attack surface:
Ref: https://raesene.github.io/blog/2017/04/02/Kubernetes-Service-Tokens/

So - is it time enable RBAC by default?
Can we just enable it since v0.9.7(the next release), or hopefully v0.9.8?

@danielfm
Copy link
Contributor

My vote is "yes". The sooner the better.

@gianrubio
Copy link
Contributor

gianrubio commented May 17, 2017 via email

@camilb
Copy link
Contributor

camilb commented May 17, 2017

My vote is yes. In GKE, RBAC is enabled by default on all container clusters running Kubernetes version 1.6 or later.

@Fsero
Copy link
Contributor

Fsero commented May 17, 2017 via email

@cknowles
Copy link
Contributor

When we do this, we can likely remove the note in cluster.yaml that says a minimum set of role bindings must be added since they were added in #316 so I think kube-aws works OOTB now.

@mumoshu mumoshu added this to the v0.9.9-rc.1 milestone Jul 3, 2017
mumoshu added a commit to mumoshu/kube-aws that referenced this issue Aug 30, 2017
camilb added a commit to camilb/kube-aws that referenced this issue Oct 9, 2017
…-aws

* 'master' of https://github.com/kubernetes-incubator/kube-aws: (55 commits)
  Bump default k8s to 1.7.5
  Fix the scheduling and permissions issue of CA by fixing the conditional in stack-template.json for worker and controller stacks, while making configuration easier.
  Fix tests
  Read worker-ca-key.pem instead of ca-key.pem when certs are managed by kube-aws and TLS bootstrapping is enabled. Formerly, ca-key.pem was read to be install on controller nodes to support TLS boostrapping. However, we have the CA dedicated for TLS boootstrapping today, instead of the one used more widely.
  Fix the bug that symlinks under `credentials` were not accessible from anywhere other than the parent of the `credentials` dir
  Fix the bug that the contents of ca-key.pem was that of ca.pem
  Add more informational log messages to the render-credentials command
  Fix a degradation in message ordering As explained in kubernetes-retired#877 (comment)
  Fix the existing CA support It seems to have broken at some point.
  Fix the json parsing error when clusterAutoscalerSupport is enabled on node pools
  Fix too permissive IAM policy for CA associated to controller nodes Fix kubernetes-retired#903
  Add spot fleet support for the `awsNodeLabels` feature Resolves kubernetes-retired#803
  Drop the ability to disable RBAC via cluster.yaml
  Enable RBAC by default Resolves kubernetes-retired#655
  Fix the hard-coded duration until an etcd cert generated by kube-aws expires Fix kubernetes-retired#892
  Fix test timeouts in CI Resolves kubernetes-retired#893
  Fix ca-key.pem handling and tests
  Create symlinks in test helpers
  Dedicated worker CA and Etcd trusted CA bundle
  Fix encrypted files regen tests
  ...
kylehodgetts pushed a commit to HotelsDotCom/kube-aws that referenced this issue Mar 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants