Add TLS protocol #153
Merged
Add TLS protocol #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Jun 30, 2021
mxinden
approved these changes
Jun 30, 2021
There was a problem hiding this comment.
This looks good to me from the multiformats perspective. I can not comment on the Go side.
I think we should wait for a sign-off by @marten-seemann as well to ensure this is consistent long term with QUIC and HTTP3.
marten-seemann
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added TLS protocol. There are plenty of applications of TLS protocol not in the context of using it with
httporws(e.g. ingPRC), so it seems logical to add it. Code for it was taken from multicodec repo.There is multiformats/multiaddr#109 PR that suggests adding TLS protocol, mark
httpsandwssprotocols as deprecated and start using/tls/httpand/tls/wsinstead.