bug: missing support for /tls multiaddr

[danisharora099]

• Version: 0.46.x
• Platform: macos
• Subsystem: Dialer

Severity: High

Description:

js-libp2p throws an error Unsupported protocol tsl when a multiaddr /ip4/192.168.68.58/tcp/433/tls/ws/p2p/16Uiu2HAkyZuLQy4sPRte7khemYHmkQewzjdTPRXZcxPH6NgjhR97 is dialed

The expectation is that a secure websocket multiaddr would have /wss/ but apparently wss was replaced by /tls/ws:

• Add TLS protocol multiformats/go-multiaddr#153
• Add TLS as per GH/multiformats/multicodec#145 multiformats/multiaddr#109
• Is /https deprecated? multiformats/multiaddr#163

Steps to reproduce the error:

Try to dial /ip4/192.168.68.58/tcp/433/tls/ws/p2p/16Uiu2HAkyZuLQy4sPRte7khemYHmkQewzjdTPRXZcxPH6NgjhR97 through js-libp2p

[maschad]

Could you share the example where you tried to dial this address? as well as the dependencies of the listening node and the environment?

You are correct in that wss was deprecated although we still utilize it internally in our monorepo tests,

but it's strange that you get this error since there's support for backwards compatibility that is tested in multiaddrs

I have tried to dial the multiaddr you shared but I am getting a timeout error ( I assume the node isn't running at that public IP at the moment).

But I am able to have two local nodes dial each other with the current format as such:

import { createLibp2p } from 'libp2p'
import { webSockets } from '@libp2p/websockets'
import { mplex } from '@libp2p/mplex'
import { noise } from '@chainsafe/libp2p-noise'
import { yamux } from '@chainsafe/libp2p-yamux'
import { tcp } from '@libp2p/tcp'
import { identifyService } from 'libp2p/identify'

const node1 = await createLibp2p({
   addresses: {
    listen: ['/ip4/127.0.0.1/tcp/8000/tls/ws']
  },
  transports: [
    tcp(),
    webSockets()
  ],
  streamMuxers: [yamux(), mplex()],
  connectionEncryption: [noise()],
  services: {
    identify: identifyService()
  }
})

const node2 = await createLibp2p({
   addresses: {
    listen: ['/ip4/127.0.0.1/tcp/8001/tls/ws']
  },
  transports: [
    tcp(),
    webSockets()
  ],
  streamMuxers: [yamux(), mplex()],
  connectionEncryption: [noise()],
  services: {
    identify: identifyService()
  }
})

await node1.start()
await node2.start()

const connection = await node1.dial(node2.getMultiaddrs()[0])

console.log('node1 is connected to node2:', connection.status)
// Status is logged as open

[achingbrain]

Could you also confirm the version of @multiformats/multiaddr you have installed? /tls support was only added in 11.4.0 -

$ npm ls @multiformats/multiaddr

[danisharora099]

ah, found the problem!

it's actually coming from an older version of @multiformats/multiaddr-to-uri before it supported it

the problem is that @libp2p/websockets does not have the dependency upgraded to where it supports tls -- currently uses 9.0.2 while support for it was introduced on 9.0.5
multiformats/js-multiaddr-to-uri#120

[danisharora099]

opened a PR for this here: #2059

[maschad]

Closing as #2059 (comment) should solve the issue