Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to query editor layout #693

Merged
merged 3 commits into from
Jul 27, 2022
Merged

Fixes to query editor layout #693

merged 3 commits into from
Jul 27, 2022

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jul 26, 2022 •
edited
Loading

Recommended to hide whitespace while reviewing

Fixes #692

  • We can keep the methodology from Add split panes to connections dialog #676, it's sound
  • Give explicit height to the DialogContent, this solved most of the problems
  • Fix layout/overflow issues from QueryEditor layout issues #692 (looks like they were introduced way before)
  • Invert the logic one how we display the legacy view. We now have an implicit to do list in LEGACY_DATASOURCE_QUERY_EDITOR_LAYOUT that we can tackle one by one
  • Remove some legacy comments
  • Remove some leftover? height: 500px

@render
Copy link

render bot commented Jul 26, 2022

Your Render PR Server URL is https://toolpad-pr-693.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cbg0rt82i3mquga0rb1g.

@oliviertassinari oliviertassinari requested a deployment to query-editor-layout-fixes - toolpad-db PR #693 July 26, 2022 15:53 — with Render Abandoned
@Janpot Janpot requested a review from bytasv July 26, 2022 16:42
@Janpot Janpot merged commit 2132730 into master Jul 27, 2022
@Janpot Janpot deleted the query-editor-layout-fixes branch July 27, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bytasv bytasv bytasv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QueryEditor layout issues
3 participants
@Janpot @bytasv @oliviertassinari