Add split panes to connections dialog #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://toolpad-pr-676.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cbcm9lsgqg4c3s69c3d0. |
oliviertassinari
requested a deployment
to
split-panes-for-rest-and-sheets - toolpad-db PR #676
Render
Abandoned
bytasv
force-pushed
the
split-panes-for-rest-and-sheets
branch
from
5fcb97c
to
0ddec78
Compare
Janpot
approved these changes
Jul 24, 2022
|
Your Render PR Server URL is https://toolpad-pr-676.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cbf4ojli0e810m4358f0. |
oliviertassinari
requested a deployment
to
split-panes-for-rest-and-sheets - toolpad-db PR #676
Render
Abandoned
|
Closes #662 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added
SplitPanehowever I'm not a big fan of implementation right now. I had to addConnectionWrapperwhich is a pretty dumb component which allows either to use split pane or not. I think to do it more cleaning we would need to refactor layout and maybe unify each connection type 🤔