[code infra] migrate to pnpm #2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
Closed
Merged
11 tasks
LukasTy
reviewed
Apr 8, 2024
| @@ -16,21 +16,22 @@ | |||
| "toolpad": "./dist/index.js" | |||
| }, | |||
| "scripts": { | |||
| "preinstall": "npx only-allow pnpm", | |||
There was a problem hiding this comment.
Nitpick: I'm not sure how necessary is this.
Trying to run yarn on a pnpm setup produces the following error:
error This project's package.json defines "packageManager": "yarn@[email protected]". However the current global version of Yarn is 1.22.21.
Presence of the "packageManager" field indicates that the project is meant to be used with Corepack, a tool included by default with all official Node.js distributions starting from 16.9 and 14.19.
Corepack must currently be enabled by running corepack enable in your terminal. For more information, check out https://yarnpkg.com/corepack.Am I missing something or this script can actually be omitted? 🤔
There was a problem hiding this comment.
I believe that error only appears when corepack is enabled. There are older versions of yarn which would happily install even though the packageManager field exists. e.g. I was able to install with [email protected] (not through corepack) when I remove the preinstall script.
There was a problem hiding this comment.
Gotcha. Then it makes sense to add it in. 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating yarn to pnpm
benchmark
I just compared 4 CI runs, not doing any serious statistics here
First number is cache restoration step, second number is the install step.
deduplication takes more time in pnpm than in yarn. We can mitigate the effect by only running it when the lock file has changed.