[code-infra] Change package manager to `pnpm` #11875

LukasTy · 2024-01-31T13:03:19Z

CI runtime improvement

Before: ~20mins
After: ~16mins

Replicate the migrations already done on mui/material-ui#36287 and mui/toolpad#2546.

IMHO, this change https://github.com/mui/material-ui/pull/36287/files#diff-8ee0a5d567f55f7e7507f6cd79d9c37721906efe84f500acc89c551508c43464 deserves to be delivered via a separate PR to reduce the unwanted noise. 🤔

Progress

Build output comparison

There are 732 files with diffs (some of them expected - package.json) comparing the current build output with yarn and this branch.

The most notable changes repeated in many files in most packages:

{} instead of Object.prototype:

-function _interopRequireWildcard(e, r) { if (!r && e && e.__esModule) return e; if (null === e || "object" != typeof e && "function" != typeof e) return { default: e }; var t = _getRequireWildcardCache(r); if (t && t.has(e)) return t.get(e); var n = { __proto__: null }, a = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var u in e) if ("default" !== u && Object.prototype.hasOwnProperty.call(e, u)) { var i = a ? Object.getOwnPropertyDescriptor(e, u) : null; i && (i.get || i.set) ? Object.defineProperty(n, u, i) : n[u] = e[u]; } return n.default = e, t && t.set(e, n), n; }
+function _interopRequireWildcard(e, r) { if (!r && e && e.__esModule) return e; if (null === e || "object" != typeof e && "function" != typeof e) return { default: e }; var t = _getRequireWildcardCache(r); if (t && t.has(e)) return t.get(e); var n = { __proto__: null }, a = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var u in e) if ("default" !== u && {}.hasOwnProperty.call(e, u)) { var i = a ? Object.getOwnPropertyDescriptor(e, u) : null; i && (i.get || i.set) ? Object.defineProperty(n, u, i) : n[u] = e[u]; } return n.default = e, t && t.set(e, n), n; }

Changed attributes order in d.ts files and removal of reference comments (i.e. /// <reference types="@react-spring/shared" />)
Combine jsx-runtime imports.

Note

This looks like a "bugfix" to me.

-import { jsx as _jsx } from "react/jsx-runtime";
-import { jsxs as _jsxs } from "react/jsx-runtime";
+import { jsx as _jsx, jsxs as _jsxs } from "react/jsx-runtime";

Remove explicit undefined for optional fields, i.e.:

Note

This is due to a bump of typescript. Bumping it on yarn produces the same result.

packages/x-data-grid/build/hooks/features/columnHeaders/useGridColumnHeaders.d.ts
-pinnedPosition?: GridPinnedColumnPosition | undefined;
+pinnedPosition?: GridPinnedColumnPosition;

Use eligible imports in GridPremiumColumnMenu.d.ts:

Note

This is due to a bump of typescript. Bumping it on yarn produces the same result.

This looks like a bugfix to me. 🤔 P.S. `This branch` build on the **right** and `master` build on the **right**.

The exploration for ditching babel-loader (no longer relevant as the problem has been fixed in a different way):

The easiest way to make tests happy is by changing babel to tsx for test compilation
- This is not trivial because we want to keep testing both date-fns@v2 and date-fns@v3 adapters on Pickers side and their testing implementation currently relies on hackily replacing imports on our predefined rules using a patched babel plugin.
- I've explored creating a separate package just to test date-fns@v3, but that doesn't work nicely, because the resolved version of date-fns is still v2, because it comes (is used) from a dev dependency on @mui/x-date-pickers event though this package specifies and resolves "date-fns": "^3.6.0". 🙈

LukasTy · 2024-04-22T12:37:59Z

package.json

    "tsx": "^4.7.0",
-    "typescript": "^5.3.3",
+    "typescript": "^5.4.5",


Had to bump to avoid problems with TS being unable to correctly resolve linked deps in a monorepo.
microsoft/TypeScript#42873 (comment)

packages/x-data-grid/tsconfig.build.json

Janpot · 2024-04-22T15:24:23Z

packages/x-charts/tsconfig.build.json

@@ -8,9 +8,16 @@
    "noEmit": false,
    "emitDeclarationOnly": true,
    "outDir": "build",
-    "rootDir": "./src"
+    "rootDir": "./src",
+    "types": [


Yes, this is great! Is there a reason to not place it directly in tsconfig.json? I feel like it would be beneficial to keep the config for typechecking as close as possible to the one for type generation. This file should adopt the setting automatically through the extends.

I never really understood why we have a separate tsconfig for the build.
@LukasTy @Janpot Can you enlighten me, please? 🙂

If I understand correctly, two reasons

for typechecking we use noEmit: true and for type generation we use noEmit: false. But I believe this should be achievable through a cli flag as well.

for type generation we're working towards a setup with a single compilation using project references instead of a compilation per project. But I hope we can bring this setup to type checking as well.

cc @michaldudak will be able to shed some more light, I may be a bit off on this.

But I hope we can bring this setup to type checking as well.

This is already set up like this in the Base UI repo. However, it doesn't work perfectly (yet), as it doesn't typecheck tests.

for typechecking we use noEmit: true and for type generation we use noEmit: false. But I believe this should be achievable through a cli flag as well.

True. I believe all settings are available through commandline flag. It's a matter of readability to create a config file.

In addition to what @Janpot wrote, the build config also excludes tests from the output.

cherniavskii · 2024-04-22T16:31:51Z

package.json

Any ideas why I can't install dependencies?
I've removed my node_modules before pnpm install

Did you use corepack enable to install pnpm? Can you try that?

Otherwise, if you installed it separately, you may take a look at this issue and remove pnpm from your PATH variable and let corepack take over.

I installed using this script https://pnpm.io/8.x/installation#on-posix-systems

you may take a look at pnpm/pnpm#3016 (comment) and remove pnpm from your PATH variable and let corepack take over.

That didn't help, but sudo corepack enable pnpm did, thanks!

cherniavskii

Looks good as far as I'm concerned!
Thanks for working on this! 🎉

Janpot

Great effort!

LukasTy · 2024-04-24T14:46:10Z

scripts/README.md

@@ -5,6 +5,9 @@
 > Tip: For people who are doing the release for the first time, make sure you sign in to npm from the command line using security-key flow as well as have two-factor authentication enabled.
 > You can follow [this guide](https://docs.npmjs.com/accessing-npm-using-2fa) for more information on how to set it up.

+> Tip: You can use `release:publish:dry-run` to test the release process without actually publishing the packages.


@michaldudak I've added a tip here to spread more knowledge as I wasn't aware of this option before working on this PR. 🙈

Signed-off-by: Lukas <[email protected]> Co-authored-by: Jose Quintas <[email protected]>

LukasTy added 16 commits January 30, 2024 15:33

specify package manager

26636c1

Generate pnpm-lock

dba95e9

define pnpm workspace

e8e915a

Remove yarn.lock

78b2c2f

Replace deprecated proposals with transform packages

1920b08

sync transform versions

a72fd80

run install

55719c9

npmrc

7f9a5c6

Downgrade monorepo to current version

d72dd0c

Replace yarn calls with pnpm

8d02d44

Use workspace:* for direct monorepo deps

d66ccfd

Remove yarn-deduplicate

2ad73e3

Update remaining scripts

1c03ce9

Specify publish directory

a3122b8

Remove not used @trendmicro/react-interpolate package

2482ab5

Replace remaining yarn usages

0591518

LukasTy added core Infrastructure work going on behind the scenes scope: code-infra Specific to the core-infra product labels Jan 31, 2024

LukasTy self-assigned this Jan 31, 2024

LukasTy added 11 commits January 31, 2024 16:20

Refactor patches into pnpm solution

edc8b44

fix eslint

0f48bed

Add @types/prop-types where necessary

0b830ab

Fix moment-hijri missing types

6a5c146

Fix data-grid typing issues

87d93fb

Fix missing import in docs

a085a5a

Fix docs packages

eecb512

Fix remaining docs package TS issues

597745f

Add missing dev packages

9a52d23

Make typescript happy

d1420dc

Fix build

06a3927

LukasTy added 5 commits April 22, 2024 15:20

Bump typescript to fix x-data-grid-premium buildTypes

911f5ca

Further Data Grid package tsconfig simplifications

9f4fec3

Remove unused entry

fe04389

Simplify Tree View tsconfig

23355c7

prettier

34cfe46

LukasTy commented Apr 22, 2024

View reviewed changes

LukasTy added 2 commits April 22, 2024 16:38

Merge remote-tracking branch 'upstream/master' into yarn-to-pnpm

ee4c36d

Add engine-strict

98807b0

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 22, 2024

LukasTy commented Apr 22, 2024

View reviewed changes

packages/x-data-grid/tsconfig.build.json Show resolved Hide resolved

Janpot reviewed Apr 22, 2024

View reviewed changes

cherniavskii reviewed Apr 22, 2024

View reviewed changes

Simplify license tsconfig

ef331f7

cherniavskii approved these changes Apr 23, 2024

View reviewed changes

Janpot approved these changes Apr 24, 2024

View reviewed changes

LukasTy added 3 commits April 24, 2024 16:37

Omit pnpm cache

14701d9

Merge remote-tracking branch 'upstream/master' into yarn-to-pnpm

dd410a7

Fix release scripts

77d3ddf

LukasTy mentioned this pull request Apr 24, 2024

[code-infra] Fix release:publish:dry-run script mui/material-ui#42018

Closed

LukasTy added 3 commits April 24, 2024 17:32

Revert to original dry-run script solution

0f60f5f

Add note about release:publish:dry-run usage

3fc38db

Simplify docs and test package tsconfig

e620216

LukasTy commented Apr 24, 2024

View reviewed changes

prettier

0bc1da9

LukasTy merged commit 931fd6e into mui:master Apr 24, 2024
17 checks passed

LukasTy deleted the yarn-to-pnpm branch May 17, 2024 15:02

LukasTy mentioned this pull request May 17, 2024

[core] Rename yarn to pnpm in PropTypes comment #13167

Merged

Crihojames mentioned this pull request Jun 1, 2024

[Snyk] Upgrade @mui/x-data-grid from 7.0.0 to 7.4.0 Crihojames/Dashboard-website#2

Open

DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024

[code-infra] Change package manager to pnpm (mui#11875)

cf6529b

Signed-off-by: Lukas <[email protected]> Co-authored-by: Jose Quintas <[email protected]>

thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024

[code-infra] Change package manager to pnpm (mui#11875)

9654c85

Signed-off-by: Lukas <[email protected]> Co-authored-by: Jose Quintas <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[code-infra] Change package manager to `pnpm` #11875

[code-infra] Change package manager to `pnpm` #11875

LukasTy commented Jan 31, 2024 •

edited

Loading

LukasTy Apr 22, 2024

Janpot Apr 22, 2024 •

edited

Loading

cherniavskii Apr 22, 2024

Janpot Apr 22, 2024 •

edited

Loading

michaldudak Apr 23, 2024

cherniavskii Apr 22, 2024

Janpot Apr 23, 2024

cherniavskii Apr 23, 2024

cherniavskii left a comment

Janpot left a comment

LukasTy Apr 24, 2024

[code-infra] Change package manager to pnpm #11875

[code-infra] Change package manager to pnpm #11875

Conversation

LukasTy commented Jan 31, 2024 • edited Loading

CI runtime improvement

Progress

Build output comparison

The exploration for ditching babel-loader (no longer relevant as the problem has been fixed in a different way):

LukasTy Apr 22, 2024

Choose a reason for hiding this comment

Janpot Apr 22, 2024 • edited Loading

Choose a reason for hiding this comment

cherniavskii Apr 22, 2024

Choose a reason for hiding this comment

Janpot Apr 22, 2024 • edited Loading

Choose a reason for hiding this comment

michaldudak Apr 23, 2024

Choose a reason for hiding this comment

cherniavskii Apr 22, 2024

Choose a reason for hiding this comment

Janpot Apr 23, 2024

Choose a reason for hiding this comment

cherniavskii Apr 23, 2024

Choose a reason for hiding this comment

cherniavskii left a comment

Choose a reason for hiding this comment

Janpot left a comment

Choose a reason for hiding this comment

LukasTy Apr 24, 2024

Choose a reason for hiding this comment

[code-infra] Change package manager to `pnpm` #11875

[code-infra] Change package manager to `pnpm` #11875

LukasTy commented Jan 31, 2024 •

edited

Loading

Janpot Apr 22, 2024 •

edited

Loading

Janpot Apr 22, 2024 •

edited

Loading