Fix changing tabs closing query editor #1784
Conversation
| @@ -130,8 +130,12 @@ export default function QueryEditor() { | |||
| const { queries = [] } = appDom.getChildNodes(dom, page) ?? []; | |||
|
|
|||
| const handleEditStateDialogClose = React.useCallback(() => { | |||
| appStateApi.setView({ kind: 'page', nodeId: page.id }); | |||
| }, [appStateApi, page.id]); | |||
| if (!dialogState?.isDraft) { | |||
There was a problem hiding this comment.
Prefer positive logic
| if (!dialogState?.isDraft) { | |
| if (dialogState?.isDraft) { | |
| setDialogState(null); | |
| // ... |
| if (currentView.kind === 'page' && currentView.view?.kind === 'query') { | ||
| const node = appDom.getNode(dom, currentView.view?.nodeId, 'query'); | ||
| return { node, isDraft: false }; | ||
| } | ||
|
|
||
| return null; | ||
| if (!dialogState?.isDraft) { |
There was a problem hiding this comment.
Same,
| if (!dialogState?.isDraft) { | |
| if (dialogState?.isDraft) { | |
| return previousState; | |
| } | |
| return null; |
| }); | ||
| }, [dom, currentView]); | ||
| }, [dom, currentView, dialogState?.isDraft]); |
There was a problem hiding this comment.
Perhaps extract this in a variable and reuse?
const isDraft = !!dialogState?.isDraft;
Not sure, this was quite a specific issue since it involves switching tabs. The |
I've modified the |
Closes #1742
margin: autoin the page node.Screen.Recording.2023-03-22.at.20.03.43.mov