Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query editor in draft state closes after switching tabs #1742

Closed
2 tasks done
Janpot opened this issue Mar 13, 2023 · 3 comments · Fixed by #1784
Closed
2 tasks done

Query editor in draft state closes after switching tabs #1742

Janpot opened this issue Mar 13, 2023 · 3 comments · Fixed by #1784
Assignees
@apedroferreira
Labels
bug 🐛 Something doesn't work
Milestone
Toolpad Core MVP

Comments

@Janpot
Copy link
Member

Janpot commented Mar 13, 2023 •
edited
Loading

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Steps to reproduce 🕹

This issue concerns the branch #1651

  1. click add query
  2. select "serverside HTTP request"
  3. switch tabs
  4. switch back to the editor
Screen.Recording.2023-03-13.at.17.54.19.mov

Current behavior 😯

The query editor closes

Expected behavior 🤔

The query editor is still open

Context 🔦

No response

Your environment 🌎

No response
@Janpot Janpot added the bug 🐛 Something doesn't work label Mar 13, 2023
@apedroferreira
Copy link
Member

Argh, I can take a look at it.

@Janpot
Copy link
Member Author

Janpot commented Mar 13, 2023

@apedroferreira I thought at first it was related to the recent router changes, but it doesn't seem to happen on master

@apedroferreira
Copy link
Member

apedroferreira commented Mar 13, 2023 •
edited
Loading

@apedroferreira I thought at first it was related to the recent router changes, but it doesn't seem to happen on master

Ok, I thought so too, I can take a deeper look later anyway.

@prakhargupta1 prakhargupta1 added this to the pro-code MVP milestone Mar 20, 2023
@apedroferreira apedroferreira mentioned this issue Mar 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apedroferreira apedroferreira

Labels
bug 🐛 Something doesn't work
Projects
None yet
Milestone
Toolpad Core MVP
Development

Successfully merging a pull request may close this issue.

Fix changing tabs closing query editor mui/toolpad
3 participants
@Janpot @apedroferreira @prakhargupta1