-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Fix onPageChange
firing too often
#838
Conversation
@dtassone Regarding the format of the pull request, I would recommend the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have commented on my understanding of how it should behave. The mental model I have always seen for the change event is: "does something try to change the current state?". For instance, when doing server-side rendering, the default page is already 1, I don't see why it should fire.
onPageChange
firing too often
Fix #816, onPageChange firing multiple times