-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Events firing multiple times and also while table initially renders #816
Comments
Hi @dheeraj1447 thanks for reporting this, it is indeed an issue. We will take a look at it. |
I have updated the reproduction to use DataGrid, focusing on the MIT version should be enough as it reproduces the same bugs as XGrid. Regarding the expected behavior, I would go even further than @dheeraj1447 has suggested. I would also encourage to change the signature of the callback. I would expect |
I agree, the reason why it fires 3 times is not that the page changes but because the pagination state is being updated (items per page, total pages etc.). |
Thanks @oliviertassinari and @DanailH for your quick response. I also agree with @oliviertassinari as the current table uses |
The same thing is happening with |
@helissonms @missbruni You can subscribe to #2635 for the |
Current Behavior 😯
Expected Behavior 🤔
Steps to Reproduce 🕹
DataGrid: https://codesandbox.io/s/material-demo-forked-9jzwr?file=/package.json
XGrid: https://codesandbox.io/s/material-demo-forked-8dylq?file=/demo.tsx
Steps:
Context 🔦
Your Environment 🌎
`npx @material-ui/envinfo`
The text was updated successfully, but these errors were encountered: