Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Remove partial Portuguese and Chinese translations of the pickers pages #6893

Merged
merged 1 commit into from
Nov 17, 2022
Merged

[docs] Remove partial Portuguese and Chinese translations of the pickers pages #6893

merged 1 commit into from
Nov 17, 2022

Conversation

flaviendelangle
Copy link
Member

Should have done that months ago.
I want to do it before duplicating these pages for the new pickers to avoid wasting time on them.

The fallback on the English page works great, the next step will be to do like mui/material-ui#34820

@flaviendelangle flaviendelangle self-assigned this Nov 17, 2022
@flaviendelangle flaviendelangle added docs Improvements or additions to the documentation component: pickers This is the name of the generic UI component, not the React module! labels Nov 17, 2022
@flaviendelangle flaviendelangle changed the title [docs] Remove partial translations in PT and ZH of the pickers [docs] Remove partial Portuguese and Chinese translations of the pickers pages Nov 17, 2022
@flaviendelangle flaviendelangle marked this pull request as draft November 17, 2022 13:23
@mui-bot
Copy link

mui-bot commented Nov 17, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-6893--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 636 1,111 636.9 813.86 199.373
Sort 100k rows ms 646.7 1,085.6 646.7 924.52 152.667
Select 100k rows ms 231.3 324.8 293 292.88 33.874
Deselect 100k rows ms 133.2 210.5 195.2 178.1 30.459

Generated by 🚫 dangerJS against 3a2b191

@flaviendelangle flaviendelangle marked this pull request as ready for review November 17, 2022 15:08
@flaviendelangle flaviendelangle merged commit b8c84b4 into mui:next Nov 17, 2022
@flaviendelangle flaviendelangle deleted the remove-pt-zh-docs branch November 17, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

@joserodolfofreitas joserodolfofreitas Awaiting requested review from joserodolfofreitas

Assignees

@flaviendelangle flaviendelangle

Labels
component: pickers This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flaviendelangle @mui-bot @LukasTy