[docs] Disable translations #34820

mnajdova · 2022-10-19T06:32:03Z

Would be great if someone can double check the redirects, are those that I've added enough?

mui-bot · 2022-10-19T06:34:25Z

	Messages
📖	Netlify deploy preview: https://deploy-preview-34820--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 17d66c3

cherniavskii · 2022-10-19T09:23:13Z

docs/pages/_app.js

@@ -39,39 +32,6 @@ const clientSideEmotionCache = createEmotionCache();
 // Set the locales that the documentation automatically redirects to.
 acceptLanguage.languages(LANGUAGES);

-function LanguageNegotiation() {


We should do the same in MUI X and synchronize docs deployment to production to avoid redirect loop for users that previously selected language different than en.
Here's what happens on preview deployment when user has userLanguage=pt cookie:

Screen.Recording.2022-10-19.at.11.17.20.mov

I'll open a PR

Nice catch, let's keep this in mind.

mui/mui-x#6560

docs/pages/_app.js

cherniavskii · 2022-10-19T09:32:50Z

docs/src/modules/constants.js

@@ -4,10 +4,10 @@ const CODE_VARIANTS = {
 };

 // Valid languages to server-side render in production
-const LANGUAGES = ['en', 'zh', 'pt'];
+const LANGUAGES = ['en'];


Do we need these constants? They're used in next.config.js, but maybe we should remove translation logic there as well?

We discussed that we want to keep the infrastructure around the translations so that we can easily add it back if we decide in the future, this is why I decided to left these constants and not do any changes in the next.config.js, but I don't mind removing the logic there as well. cc @siriwatknp what do you think?

~~Let's remove them too.~~ There are many places that use LANGUAGES, so I think let's keep them there, otherwise it will be a lot more work. The changes are sufficient.

cherniavskii · 2022-10-19T10:12:06Z

docs/public/_redirects

+/pt/* /:splat 301
+/zh/* /:splat 301


Suggested change

/pt/* /:splat 301

/zh/* /:splat 301

/pt/material-ui/* /material-ui/:splat 301

/zh/material-ui/* /material-ui/:splat 301

/pt/joy-ui/* /joy-ui/:splat 301

/zh/joy-ui/* /joy-ui/:splat 301

/pt/base/* /base/:splat 301

/zh/base/* /base/:splat 301

/pt/system/* /system/:splat 301

/zh/system/* /system/:splat 301

We can do this instead to avoid #34820 (comment) and keep /x redirects independent.
This will allow us to disable translations in MUI X in our own pace.
What do you think?

Makes sense 👍 Would the translation on x still work if this PR gets merged tough?

BTW now that this is committed, make sure to add the redirects in mui/mui-x#6560

Makes sense 👍 Would the translation on x still work if this PR gets merged tough?

I think so - we still have LanguageNegotiation in our docs.

cc @bharatkashyap should we do something similar for toolpad? Is there support for translations there as well?

No, @mnajdova, there's no need for this in Toolpad since we don't have translations at the moment.

@bharatkashyap
I would suggest removing LanguageNegotiation in Toolpad docs then:
https://github.com/mui/mui-toolpad/blob/3dccbbe1d4cb992acee77c775c73159beb785b4d/docs/pages/_app.js#L200

Because if you go to https://mui.com/toolpad/getting-started/overview/ and change language - you'll get 404:
https://mui.com/pt/toolpad/getting-started/overview/

Co-authored-by: Andrew Cherniavskii <[email protected]> Signed-off-by: Marija Najdova <[email protected]>

oliviertassinari

To see if the service workers that developers have previously installed could lead to infinite loops. Can this happen?

I open http://mui.com/
The page is served by my service worker (an older version), and I have pt as the selected language.
The JavaScript logic HTTP redirects me to http://mui.com/pt/
The new direction we add here HTTP redirects me to http://mui.com/, I'm back to 1. 🔁

How to solve this? One option is to first discontinue language negation of step 3. Release the changes, wait ~a month for the logic to propagate to the cache of people, and do the rest of the changes proposed here.
Another option is at the service worker level. Maybe when it goes from step 4 to 1, the new service worker logic will activate, and break the loop. So maybe we are already good.

Otherwise, it can't think of anything else that could go wrong, it looks good

docs/public/_redirects

Co-authored-by: Olivier Tassinari <[email protected]> Signed-off-by: Marija Najdova <[email protected]>

mnajdova · 2022-10-19T14:37:37Z

How to solve this? One option is to first discontinue language negation of step 3. Release the changes, wait ~a month for the logic to propagate to the cache of people, and do the rest of the changes proposed here.
Another option is at the service worker level. Maybe when it goes from step 4 to 1, the new service worker logic will activate, and break the loop. So maybe we are already good.

It is a bit risky to test this out by going directly to production. The first option looks safer, I don't mind going with it. @mui/docs-infra do you have a preference?

siriwatknp

I guess the cleanup of the translation files will be a follow-up PR, right?

oliviertassinari · 2022-10-20T09:03:16Z

@siriwatknp I would personally keep them so it keeps working in dev mode, and until we hear from Albert on whether he's interested in having a focus on growing the Chinese community or not.

mnajdova · 2022-10-20T10:32:13Z

I guess the cleanup of the translation files will be a follow-up PR, right?

I second what Olivier said. The goal is to just disable the changing of the languages for now.

flaviendelangle · 2022-10-20T10:35:11Z

@siriwatknp I would personally keep them so it keeps working in dev mode, and until we hear from Albert on whether he's interested in having a focus on growing the community in the Chinese market or not.

For the picker doc on X where the translations are totally out of date and basically useless, can we remove them altogether ?
Or at least reset them to avoid misleading content.

oliviertassinari · 2022-10-20T13:22:42Z

X where the translations are totally out of date and basically

@flaviendelangle I think that https://github.com/mui/mui-x/blob/3f2cb51abf2c9456f2a5f7d7bdf1b0b9bc22f969/docs/data/date-pickers/date-picker/date-picker-zh.md is only here because we copied the source from mui/material-ui, we are not synching mui/mui-x with Crowdin so 👍 to remove.

siriwatknp · 2022-10-21T03:45:44Z

I guess the cleanup of the translation files will be a follow-up PR, right?

I second what Olivier said. The goal is to just disable the changing of the languages for now.

Okay, let's keep them and wait for Albert's response.

mnajdova · 2022-10-21T10:01:50Z

@oliviertassinari @siriwatknp I've opened #34844 to address #34820 (review) If we decide to go with that PR, I will schedule a reminder for myself to merge this in a month.

mbrookes · 2022-10-24T18:57:45Z

It would be good to remove the Crowdin logo from the README and docs Backers section.

…a/material-ui into core/remove-translations

mnajdova · 2022-12-01T14:15:28Z

It's been a month since #34844 was merged. I will update the PR and merge it so that we can include it in the next release.

Signed-off-by: Marija Najdova <[email protected]>

oliviertassinari · 2022-12-01T18:47:56Z

Nice, should we do something for MUI X to redirect these pages https://mui.com/pt/x/react-data-grid/?

I see that we did some work on this in mui/mui-x#6639.

cherniavskii · 2022-12-29T14:20:57Z

Nice, should we do something for MUI X to redirect these pages mui.com/pt/x/react-data-grid?

I see that we did some work on this in mui/mui-x#6639.

I've opened mui/mui-x#7341 to address this

[docs] Disable translations

6882659

mnajdova added docs Improvements or additions to the documentation i18n internationalization labels Oct 19, 2022

mnajdova added 2 commits October 19, 2022 09:06

Fix lint issues

a8bdc0a

Remove unused import

e8557fe

mnajdova marked this pull request as ready for review October 19, 2022 08:16

mnajdova requested review from mbrookes and a team October 19, 2022 08:16

cherniavskii reviewed Oct 19, 2022

View reviewed changes

docs/pages/_app.js Outdated Show resolved Hide resolved

cherniavskii reviewed Oct 19, 2022

View reviewed changes

mnajdova added 2 commits October 19, 2022 11:42

Remove unnecessary package

9c5857c

Remove unused import

1f9ceff

cherniavskii reviewed Oct 19, 2022

View reviewed changes

cherniavskii mentioned this pull request Oct 19, 2022

[docs] Disable translations mui/mui-x#6560

Merged

2 tasks

Update docs/public/_redirects

b861c0d

Co-authored-by: Andrew Cherniavskii <[email protected]> Signed-off-by: Marija Najdova <[email protected]>

oliviertassinari reviewed Oct 19, 2022

View reviewed changes

docs/public/_redirects Outdated Show resolved Hide resolved

Update docs/public/_redirects

f3b9064

Co-authored-by: Olivier Tassinari <[email protected]> Signed-off-by: Marija Najdova <[email protected]>

siriwatknp reviewed Oct 20, 2022

View reviewed changes

bharatkashyap mentioned this pull request Oct 20, 2022

[website] Remove LanguageNegotation mui/toolpad#1186

Merged

siriwatknp approved these changes Oct 21, 2022

View reviewed changes

martin-fv approved these changes Oct 21, 2022

View reviewed changes

mnajdova mentioned this pull request Oct 21, 2022

[docs] Remove localization redirects #34844

Merged

mnajdova added the on hold There is a blocker, we need to wait label Oct 25, 2022

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 25, 2022

mnajdova added 2 commits October 26, 2022 11:50

Merge branch 'master' into core/remove-translations

5f6bd10

Merge branch 'core/remove-translations' of https://github.com/mnajdov…

db2336b

…a/material-ui into core/remove-translations

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 26, 2022

Remove Crowdin from README and Backers

f28bbdc

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 7, 2022

flaviendelangle mentioned this pull request Nov 17, 2022

[docs] Remove partial Portuguese and Chinese translations of the pickers pages mui/mui-x#6893

Merged

Merge branch 'master' into core/remove-translations

17d66c3

Signed-off-by: Marija Najdova <[email protected]>

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 1, 2022

mnajdova merged commit 2abad79 into mui:master Dec 1, 2022

mnajdova mentioned this pull request Dec 1, 2022

[core] Move the internal packages from docs/packages #35305

Merged

feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022

[docs] Disable translations (mui#34820)

b6cda55

cherniavskii mentioned this pull request Dec 29, 2022

[docs] Redirect translated pages mui/mui-x#7341

Merged

1 task

cherniavskii mentioned this pull request Dec 29, 2022

[core] Upgrade monorepo mui/mui-x#7344

Merged

oliviertassinari mentioned this pull request Apr 7, 2023

[website] Fix backlinks to homepage #36801

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[docs] Disable translations #34820

[docs] Disable translations #34820

mnajdova commented Oct 19, 2022 •

edited

Loading

mui-bot commented Oct 19, 2022 •

edited

Loading

cherniavskii Oct 19, 2022

cherniavskii Oct 19, 2022

mnajdova Oct 19, 2022

cherniavskii Oct 19, 2022

cherniavskii Oct 19, 2022

mnajdova Oct 19, 2022

siriwatknp Oct 20, 2022 •

edited

Loading

cherniavskii Oct 19, 2022 •

edited

Loading

mnajdova Oct 19, 2022

mnajdova Oct 19, 2022

cherniavskii Oct 19, 2022

mnajdova Oct 19, 2022

bharatkashyap Oct 19, 2022

cherniavskii Oct 19, 2022

oliviertassinari left a comment •

edited

Loading

mnajdova commented Oct 19, 2022

siriwatknp left a comment

oliviertassinari commented Oct 20, 2022 •

edited

Loading

mnajdova commented Oct 20, 2022

flaviendelangle commented Oct 20, 2022 •

edited

Loading

oliviertassinari commented Oct 20, 2022 •

edited

Loading

siriwatknp commented Oct 21, 2022

mnajdova commented Oct 21, 2022

mbrookes commented Oct 24, 2022

mnajdova commented Dec 1, 2022

oliviertassinari commented Dec 1, 2022 •

edited

Loading

cherniavskii commented Dec 29, 2022

-/pt/* /:splat 301
-/zh/* /:splat 301
+/pt/material-ui/* /material-ui/:splat 301
+/zh/material-ui/* /material-ui/:splat 301
+/pt/joy-ui/* /joy-ui/:splat 301
+/zh/joy-ui/* /joy-ui/:splat 301
+/pt/base/* /base/:splat 301
+/zh/base/* /base/:splat 301
+/pt/system/* /system/:splat 301
+/zh/system/* /system/:splat 301

[docs] Disable translations #34820

[docs] Disable translations #34820

Conversation

mnajdova commented Oct 19, 2022 • edited Loading

mui-bot commented Oct 19, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

siriwatknp Oct 20, 2022 • edited Loading

Choose a reason for hiding this comment

cherniavskii Oct 19, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oliviertassinari left a comment • edited Loading

Choose a reason for hiding this comment

mnajdova commented Oct 19, 2022

siriwatknp left a comment

Choose a reason for hiding this comment

oliviertassinari commented Oct 20, 2022 • edited Loading

mnajdova commented Oct 20, 2022

flaviendelangle commented Oct 20, 2022 • edited Loading

oliviertassinari commented Oct 20, 2022 • edited Loading

siriwatknp commented Oct 21, 2022

mnajdova commented Oct 21, 2022

mbrookes commented Oct 24, 2022

mnajdova commented Dec 1, 2022

oliviertassinari commented Dec 1, 2022 • edited Loading

cherniavskii commented Dec 29, 2022

mnajdova commented Oct 19, 2022 •

edited

Loading

mui-bot commented Oct 19, 2022 •

edited

Loading

siriwatknp Oct 20, 2022 •

edited

Loading

cherniavskii Oct 19, 2022 •

edited

Loading

oliviertassinari left a comment •

edited

Loading

oliviertassinari commented Oct 20, 2022 •

edited

Loading

flaviendelangle commented Oct 20, 2022 •

edited

Loading

oliviertassinari commented Oct 20, 2022 •

edited

Loading

oliviertassinari commented Dec 1, 2022 •

edited

Loading