Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade eslint #6738

Merged
merged 10 commits into from
Nov 21, 2022
Merged

Upgrade eslint #6738

merged 10 commits into from
Nov 21, 2022

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Nov 5, 2022 •
edited
Loading

Bringing in the changes needed to adopt mui/material-ui#34642

@mui-bot
Copy link

mui-bot commented Nov 5, 2022 •
edited
Loading

Messages
📖 Netlify deploy preview: https://deploy-preview-6738--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 676.9 1,193 740.2 898.72 183.262
Sort 100k rows ms 827 1,257.8 1,257.8 1,100.96 166.536
Select 100k rows ms 211.2 388.5 309.6 316.76 62.255
Deselect 100k rows ms 186.7 264.4 248.7 238.1 26.864

Generated by 🚫 dangerJS against 136d3c9

@Janpot Janpot added the core Infrastructure work going on behind the scenes label Nov 5, 2022
@Janpot Janpot changed the title Upgrade monorepo Upgrade monorepo dependency Nov 5, 2022
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 7, 2022
@github-actions
Copy link

github-actions bot commented Nov 7, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Nov 7, 2022
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 17, 2022
@Janpot Janpot marked this pull request as ready for review November 17, 2022 21:35
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 17, 2022
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 18, 2022
@Janpot Janpot changed the title Upgrade monorepo dependency Upgrade eslint Nov 20, 2022
@Janpot Janpot requested a review from cherniavskii November 20, 2022 18:32
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 21, 2022
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 21, 2022
cherniavskii
cherniavskii approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Jan!

@cherniavskii cherniavskii merged commit 79665e3 into mui:next Nov 21, 2022
@Janpot Janpot deleted the eslint-d branch November 21, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Janpot @mui-bot @cherniavskii