[core] Upgrade eslint-config-airbnb-typescript

[Janpot]

Tried to upgrade eslint-config-airbnb-typescript so we could use it in Toolpad.

It needed a few updates to the setup. Mainly it now requires eslint-config-airbnb to be set up separately.

The new version generates a lot of new warnings, I already ignored some of them that seem low priority to cut down on the noise, but we may want to review the remaining ones. Some of them seem legit problems. Running yarn eslint --fix gets a lot of them sorted, but I didn't push that yet to keep the noise down.

The main problems seem to center around:

• react/function-component-definition: This seems to discourage declaring components in an anonymous way. It improves the debugging experience and in some setups it may improve the hot reloading. (most of them are auto-fixable)
• react/jsx-no-useless-fragment: Some examples seem to have a top-level fragment for no reason. (most of them are auto-fixable)
• react/jsx-no-constructed-context-values: Warns for patters in React context that may cause performance issues.

Worth investing more time in this? The react/jsx-no-constructed-context-values ones seem interesting ones to solve IMO

To do before we can marge this:

• [core] Fix @typescript-eslint/default-param-last issues #34846
• [core] memoize context values for react/jsx-no-constructed-context-values #34849
• Exclude react/jsx-no-constructed-context-values for TreeView? It seems to require a lot of refactoring to stabilize it.
• Reenable the rules for .test.ts and .spec.ts and fix issues [core] ESLint fixes for tests #34924
• Fix issues on MUI X [core] Fixes for upcoming eslint upgrade mui-x#6667
• Fix issues on MUI Toolpad [core] Fixes for upcoming eslint upgrade toolpad#1249

[mui-bot]

	Messages
📖	Netlify deploy preview: https://deploy-preview-34642--material-ui.netlify.app/

Details of bundle changes

Generated by 🚫 dangerJS against a091c9d

[oliviertassinari]

If the react/jsx-no-useless-fragment reports real issues, it could be interesting to fix on its own.

Having more consistency in how we create components with react/function-component-definition sounds great.

[Janpot]

Just noticed this PR: #34637

Which is also present in the eslint output:

/tmp/material-ui/packages/mui-styles/src/StylesProvider/StylesProvider.js
  41:19  error  The 'context' object (at line 41) passed as the value prop to the Context provider (at line 73) changes every render. To fix this consider wrapping it in a useMemo hook  react/jsx-no-constructed-context-values

There's several more of these caught by the upgraded setup

[michaldudak]

It looks like we're finally close to merging this :)

[michaldudak]

I think it's good to go! Thanks for working on this!