Skip to content

[code-infra] Validate package.json fields before building #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 3, 2025
Merged

[code-infra] Validate package.json fields before building #629

merged 2 commits into from
Sep 3, 2025
+61 −12

Conversation

@brijeshb42
Copy link
Contributor

@brijeshb42 brijeshb42 commented Sep 2, 2025 •
edited
Loading

Moved some existing validations to a function and also added checks for existence of main/module/types.

Migrations PRs -

  1. [infra] Remove "main" fields from publishable packages mui-x#19407
  2. [code-infra] Remove "main" fields from publishable packages material-ui#46856
  3. Base UI is not affected since it doesn't have main field.

fixes #503

@brijeshb42 brijeshb42 added the scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). label Sep 2, 2025
@mui-bot
Copy link

mui-bot commented Sep 2, 2025 •
edited
Loading

Bundle size report

Bundle Parsed size Gzip size
@base-ui-components/react 0B(0.00%) 0B(0.00%)

Details of bundle changes

@brijeshb42 brijeshb42 marked this pull request as ready for review September 2, 2025 10:56
@brijeshb42 brijeshb42 requested a review from a team September 2, 2025 10:59
Janpot
Janpot approved these changes Sep 2, 2025
View reviewed changes
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Ok, we can go with this

@brijeshb42 brijeshb42 merged commit 2159d7e into master Sep 3, 2025
9 checks passed
@brijeshb42 brijeshb42 deleted the pkgjson-errors branch September 3, 2025 15:30
@oliviertassinari oliviertassinari changed the title [infra] Validate package.json fields before building [code-infra] Validate package.json fields before building Sep 4, 2025
@oliviertassinari oliviertassinari added the type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. label Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Janpot Janpot Janpot approved these changes

Assignees

No one assigned

Labels

scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[code-infra] Lint package.json entrypoints like main/module etc

5 participants

@brijeshb42 @mui-bot @Janpot @oliviertassinari