[code-infra] Remove "main" fields from publishable packages #46856
+31
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brijeshb42
added
the
scope: code-infra
brijeshb42
changed the title
Netlify deploy previewhttps://deploy-preview-46856--material-ui.netlify.app/ Bundle size report
|
brijeshb42
force-pushed
the
remove-main-field
branch
3 times, most recently
from
5661fb3 to
a33fdc5
Compare
brijeshb42
commented
Sep 2, 2025
| @@ -0,0 +1,71 @@ | |||
| { | |||
There was a problem hiding this comment.
Reasons for keeping it -
code-infra buildcommand is run which also generatespackage.jsonwith modifiedexportsandmainfields. If we don't keep this file, there is no way to just generate this file with the build command.esm/package.jsonis not deleted explicitly which otherwise results in errors withpnpm test:karma, specifically webpack complaining about the missingrequire.- Keeping this file as
package.jsonmakes this a package which then creates issues withnext buildof the docs since all files inside this folder are assumed as commonjs andnexttries to load something insideesm/and encounteringimport/export.
One downside is that this file gets generated only once in a while when someone runs build:lib:clean manually. This also lies outside of renovate resulting in not updating of package versions.
There was a problem hiding this comment.
I've added a script to mitigate this which essentially copies exports, main and other path fields from this file to the original package.json and writes to the build dir.
There was a problem hiding this comment.
I have removed the changes in @mui/icons-material from this PR. I'll refactor some of the build process of the package in a separate PR since that had a lot of changes unrelated to this PR.
brijeshb42
force-pushed
the
remove-main-field
branch
6 times, most recently
from
eac7527 to
b35fae8
Compare
Janpot
approved these changes
Sep 3, 2025
Also some refactor in @mui/icons-material packages. Keeping the generated package.json files in the lib directory and updated the create-typings script to add "types" field.
brijeshb42
force-pushed
the
remove-main-field
branch
from
b35fae8 to
3063b9d
Compare
zannager
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skipping the check in
@mui/icons-materialsince it needs some extra refactor which I'll open as a separate PR.