[test] Update react next patch #22105
Conversation
| // FIXME: undesired behavior, should be 1 | ||
| expect(handleBlur.callCount).to.equal(0); |
There was a problem hiding this comment.
These ones are odd. Investigating before merge
There was a problem hiding this comment.
See facebook/react#19560. focusEvent.type is now focusin. We'll see if this is expected but it's definitely different than how onMouseEnter behaves. Comparing to onMouseEnter since this is similar to onFocus in that its native event type is not equal to the react event type.
| }, | ||
| ); | ||
| }).to.throw( | ||
| 'ensureListeningTo(): received a container that was not an element node. This is likely a bug in React.', |
There was a problem hiding this comment.
See facebook/react#19558. Wouldn't mind support being dropped.
| @@ -132,8 +132,7 @@ describe('<ClickAwayListener />', () => { | |||
| expect(handleClickAway.callCount).to.equal(0); | |||
|
|
|||
| fireEvent.click(getByText('Stop inside a portal')); | |||
| // True-negative, we don't have enough information to do otherwise. | |||
| expect(handleClickAway.callCount).to.equal(1); | |||
| expect(handleClickAway.callCount).to.equal(0); | |||
There was a problem hiding this comment.
See discussion in #20406 (comment). Seems to me expected behavior matches desired behavior with react@next
There was a problem hiding this comment.
Awesome, React helps us here :): #20406 (comment)
|
Getting this in so that we're notified if behavior changes. The only concerning part about |
|
Whoops. Was not meant to be merged. |
No description provided.