Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: In react@next ShadowRoot as rootElement in ReactDOM.render crashes #19558

Closed
eps1lon opened this issue Aug 7, 2020 · 1 comment · Fixed by #15894
Closed

Bug: In react@next ShadowRoot as rootElement in ReactDOM.render crashes #19558

eps1lon opened this issue Aug 7, 2020 · 1 comment · Fixed by #15894
Labels
Component: DOM Type: Bug

Comments

@eps1lon
Copy link
Collaborator

eps1lon commented Aug 7, 2020 •
edited
Loading

React version: 0.0.0-f77c7b9d7

Steps To Reproduce

  1. Mount a component with even listeners in a ShadowRoot

Link to code example:

The current behavior

Throws with

ensureListeningTo(): received a container that was not an element node. This is likely a bug in React.

The expected behavior

  1. throw with a descriptive error that ShadowRoot is no longer supported as a root element

or

  1. continue to allow ShadowRoot as a root element

No preference here. This was just from an old regression test we had.

Will be fixed by #15894
@eps1lon eps1lon added the Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug label Aug 7, 2020
This was referenced Aug 7, 2020
Merged
Merged
@gaearon gaearon added Component: DOM Type: Bug and removed Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug labels Aug 17, 2020
@gaearon
Copy link
Collaborator

gaearon commented Aug 28, 2020

Fixed in 17.0.0-rc.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: DOM Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: React cannot render in ShadowRoot
2 participants
@gaearon @eps1lon