Fixing and improving createMenuItem#28
Merged
laoneo merged 10 commits intojoomla-projects:mainfrom Aug 7, 2024
Merged
Conversation
Update README overview commands (joomla-projects#20)
merge from head repository
- Make it working for Joomla >= 5 - Implement language selection - Refactor method documentation and unify non-use of the semicolon
Added skip tour (joomla-projects#27)
laoneo
reviewed
Aug 6, 2024
…cypress into fix-createMenuItem
merge from head repository joomla-projects/joomla-cypress
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems found while documenting and testing the functionality:
createMenuItem, working in Joomla 4, fails in Joomla 5 with:This PR makes
createMenuItemAdditional
Tests
This PR is extensively tested with test.cy.js based on joomla-cpress 1.1.0 plus #29:
Sample test output:
Created menu items are:

👉 This custom command is actual not used in Joomla System Tests.