Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new package] wasmer 4.3.5 #21608

Merged
merged 1 commit into from
Aug 10, 2024
Merged

[new package] wasmer 4.3.5 #21608

merged 1 commit into from
Aug 10, 2024

Conversation

ognevny
Copy link
Collaborator

@ognevny ognevny commented Aug 10, 2024

No description provided.

@ognevny ognevny force-pushed the add-wasmer branch 2 times, most recently from 6e72935 to d035fac Compare August 10, 2024 10:06
@ognevny
Copy link
Collaborator Author

ognevny commented Aug 10, 2024

tun-tap patch is taken from vorner/tuntap#14

@ArchGuyWu
Copy link
Contributor

@ognevny
Copy link
Collaborator Author

ognevny commented Aug 10, 2024

so patching this line will help?

@ArchGuyWu
Copy link
Contributor

so patching this line will help?

Don't know, but it's worth to try.

@ognevny ognevny force-pushed the add-wasmer branch 2 times, most recently from 16390f8 to 97c9783 Compare August 10, 2024 13:46
@ognevny ognevny marked this pull request as ready for review August 10, 2024 14:25
@ognevny ognevny merged commit 5dde3e8 into msys2:master Aug 10, 2024
8 checks passed
@ognevny ognevny deleted the add-wasmer branch August 10, 2024 14:25
@ArchGuyWu
Copy link
Contributor

It's usable.

@ArchGuyWu
Copy link
Contributor

This might also help in getting rid of some patches.

@ognevny
Copy link
Collaborator Author

ognevny commented Aug 11, 2024

This might also help in getting rid of some patches.

which? tun-tap should be with up-to-date tokio so it doesn't depend on very old windows bindings. but hardcoding IS_WINDOWS probably can be dropped

@ArchGuyWu
Copy link
Contributor

This might also help in getting rid of some patches.

which? tun-tap should be with up-to-date tokio so it doesn't depend on very old windows bindings. but hardcoding IS_WINDOWS probably can be dropped

Ok, and use llvm from msys2 to compile it maybe better.

@ognevny
Copy link
Collaborator Author

ognevny commented Aug 11, 2024

x86_64 Windows should work with everything, the problems can be only for aarch64

comment from Makefile
# Here is what works and what doesn't:
#
# * Cranelift works everywhere,
#
# * LLVM works on Linux+Darwin/`amd64`,
#   and linux+`aarch64`, linux+`riscv`
#   but it doesn't work on Darwin/`aarch64` or Windows/`aarch64`.
#
# * Singlepass works on Linux+Darwin+Windows/`amd64`,
#   and Linux+Darwin/`aarch64`
#   it doesn't work on */`riscv`.
#
# * Windows isn't tested on `aarch64`, that's why we consider it's not
#   working, but it might possibly be.
# * The Only target for `riscv` familly of processor is the RV64, with the `GC` extensions

@ArchGuyWu
Copy link
Contributor

ArchGuyWu commented Aug 11, 2024

x86_64 Windows should work with everything, the problems can be only for aarch64

comment from Makefile

# Here is what works and what doesn't:
#
# * Cranelift works everywhere,
#
# * LLVM works on Linux+Darwin/`amd64`,
#   and linux+`aarch64`, linux+`riscv`
#   but it doesn't work on Darwin/`aarch64` or Windows/`aarch64`.
#
# * Singlepass works on Linux+Darwin+Windows/`amd64`,
#   and Linux+Darwin/`aarch64`
#   it doesn't work on */`riscv`.
#
# * Windows isn't tested on `aarch64`, that's why we consider it's not
#   working, but it might possibly be.
# * The Only target for `riscv` familly of processor is the RV64, with the `GC` extensions

OK, we can try to add it for mingw64.

@ArchGuyWu
Copy link
Contributor

ArchGuyWu commented Aug 19, 2024

We can get rid of mingw-build.patch since the next version.
wasmerio/wasmer#5017 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants