Merged
Conversation
All enums, use 'modelAsString' instead of 'modelAsExtensible' streamingservice, add "Standard" to LiveEncoding.encodingType encoding, remove top and skip from query parms and add orderby accountfilters and aasetsandassefilters, remove required attribute for PresentationTimeRange properties Updated readme.md to add "opt-in-extensible-enums: true" to csharp build
…ve x-ms-azure-resource extension set to true in its hierarchy. Operation: 'Tags_CreateOrUpdate' Model: 'TagDetails' (#4600) Merging this Pull request but it might cause breaking changes on some of the SDKs
This will help service teams be better informed about the ARM API review process and add the required labels.
- requestd -> requested - visiblity -> visibility - sftware -> software
* Fix or suppress spec violations Fix R2016 by making PATCH body properties optional. Suppress the remaining 4 violations that are confirmed as false positives. * Try removing 2nd top-level heading, which _may_ have been causing a linter warning. * Fix extra indention which prevented linter from running. * Added dataStringComparisonBehavior parameter to reference data put/update spec. * Fixed grammar. * adding partitionkeyProperty to environmentInfo * changing property name * changing modelAsString * Initial checkin of spec. Unchanged from GA release other than version. * Remove .orig files * Fix validation error by removing IoTHub ES from List ES example response * Add extra example that was missing from preview spec. * Add long-term environment to resource hierarchy, and update examples. * Switch to model-as-string for enums. Restore EnvironmentResource's inheritance from TrackedResource. * Upsate sku description * Add new TSI preview api-version to readme.md. * Add suppressions for false-positive linter failures. * Test suppression failures * Adding preview package tag to several other places in readme.md * Add preview package to the readme.go.md file * Remove invalid required property from EnvironmentCreateOrUpdateParameters
- cancallation -> cancellation
- Storag -> Storage - Maxium -> Maximum
- reponse -> response - succesfully -> successfully - Successfull -> Successful - Double word "the" - GeoGraphy -> geography - secconds -> seconds - agregation -> aggregation - succesful -> successful - HttpStatusCode.Unauthorize -> HttpStatusCode.Unauthorized - fullfilled -> fulfilled - specificied -> specified - productid -> productId - appplying -> applying - assosiated -> associated - Storename -> StoreName - Managemet -> Management - outcoming -> outgoing - queruering -> querying - Countery -> Counter - Subsctions -> Subscriptions - groupid -> groupId - subid -> subscriptionId - dignostic -> diagnostic - settigs -> settings - concent -> consent - fescription -> description - Reconect -> Reconnect
- subscitption -> subscription - consoto -> contoso - adress -> address
- Double word "gallery" - metdata -> metadata
- coordianation -> coordination - updateable -> updatable - behaviour -> behavior - performExitOptionsJobAction camelcase - noAction camel case - terminateJob camel case - taskwithin -> task within - erro -> error - VNETs -> VNets
- Diplay -> Display
- specifed -> specified
- specifc -> specific - theresource -> the resource - detailes -> Details - souce -> source - occured -> occurred - cerdential -> credential - madatory -> mandatory - infomration -> information - runas -> RunAs - dratft -. draft - varible -> variable
- fullfillment -> fulfillment - deinition -> definition - policyAssginment -> policyAssignment
…4530) - opertion -> operation - ExpressRouteServiceProdiver -> ExpressRouteServiceProvider - Spepcified -> Specified - Succeded -> Succeeded
…sks (#4644) * Added diffDiskSettings property as part of Swagger changes needed for Ephemeral VM\VMSS * updated comment * updated swagger specs for diffdisksettings property * updated swagger spec comments for diff disk settings [property * added example to create Diff OS disk scaleset * updated 2018-10-01 version specs with diffdisk property * added example file for creating VM with diffdisksettings property * updated swagger changes for reimage operation in single vm * update examples * udpated examples * fixed validation errors * updated comments for reimage operation documentation
- datatimes ->datetimes - calcualte -> calculate - timezones -> time zones - blongs -> belongs - defintions -> definitions - definitons -> definitions - defitinitons -> definitions - Speficies -> Specifies - webook -> webhook - Acount -> Account - scheduledquery -> scheduled query - Frequnecy -> Frequency - Specifiy -> Specify
…ngCompute (#4707) - Operationalizaton -> Operationalization - configuartion -> configuration - Trim trailing whitespace
- compatibilty -> compatibility - capabilty -> capability
- evironments -> environments
- nodetype -> node type
…4928) - paramenters > parameters - aysnc -> async
- comptue -> compute - pre-empted -> preempted
Camel case example files
- recoverabel -> recoverable
- nuget -> NuGet - mimuntes -> minutes - repesenting -> representing - souce -> source - containting -> containing - databses -> databases - inclue -> include - Priviledged -> Privileged
- Double word "the" - Thehub -> The hub - Double word "state"
- ertificate -> certificate
…4879) - Aler -> Alert - Succesfully -> Successfully - GetbyId -> GetById
* Update specification/cost-management/resource-manager/Microsoft.CostManagement/preview/2018-08-01-preview/costmanagement.json Add more Scopes to Alerts. Also add /updateStatus to Alerts * Add billing parameter to departments * Add alert parameters
- releaseversion -> release version
#4920) - implmented -> implemented - assingment -> assignment - configuation -> configuration
…4899) * EventGrid: Update README files to include the current new preview api version 2018-09-preview * Update readme.go.md with related api version info * fix parsing failure due to missing closing ``` in readme.go.md * suppress failure due to known tool bug per approval from adxsr * Fix suppression message * add swagger and fix related examples for EventGrid 2019-01-01 API Version * Fix name mismatch in eventgrid.json in the examples to fix build failure * fix readme files to reflect correct location to eventgrid json file for stable version * remove 2019-01-01 from not dot NET multi-api sections to avoid auto-generating the corresponding SDKs * fix text * fix examples * Fix examples * Suppress failure due to known tool bug * example fixes * Adds suppression to readme
ACS will be decommissioned at the end of January, 2020. Users are encouraged to use AKS instead.
…4937) * add operation for 2018-03-31 and 2018-08-01-preview * correct example fileName * add default response and 202, correct typo
* Instance Metadata Service: Initial Commit Initial commit of Instance Metadata Service -Added Swagger for 2018-10-01 -Added examples for 2018-10-01 * Instance Metadata Service: Updates -Removed erroneous format tags -Added security section * Instance Metadata Service: Updates -Moved to imds/data-plane from imds/resource-provider * Instance Metadata Service: Added language .md files * Instance Metadata Service: Updated ErrorResponse -Removed individual error codes from operations * Instance Metadata Service: Updates to Swagger -Created separate Identity error property -Updated descriptions and added them where necessary -Created parameters section and moved api-version and Metadata to it -Renamed operationIds * Added x-ms-parameter-location to Metadata parameter * -Minor property name changes -Removed previous API versions from enum * -Fixed a typo * -Added missing descriptions * -Added more missing descriptions * -Changed openapi type to data-plane * -Added DefinitionsPropertiesNamesCamelCase suppression to readme * -Forgot one camelcase suppression * -Removed a newline
* Update SwaggerToSdk to new DockerHub address * Update swagger-to-sdk.sh
* Add PATCH API example to hanaonazure * Address PR feedback * Add Tags definiton back * Change operationId to HanaInstances_Update
…les (#4959) - Camel Case example file names - Trim trailing spaces
Same as PR #4960 Quota value should not be negative. It will output wrong document at: https://docs.microsoft.com/en-us/rest/api/azurestack/storagequotas/get
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger