Instance Metadata Service: Initial Commit by rifrankl · Pull Request #4493 · Azure/azure-rest-api-specs

rifrankl · 2018-11-16T21:56:26Z

Initial commit of Instance Metadata Service

The Azure Instance Metadata Service provides information about running virtual machine instances that can be used to manage and configure them.

-Added Swagger for 2018-10-01
-Added examples for 2018-10-01

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

Initial commit of Instance Metadata Service -Added Swagger for 2018-10-01 -Added examples for 2018-10-01

openapi-portal-comment · 2018-11-16T21:56:28Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

AutorestCI · 2018-11-16T21:56:48Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

AutorestCI · 2018-11-16T21:56:57Z

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

AutorestCI · 2018-11-16T21:56:59Z

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

AutorestCI · 2018-11-16T21:57:08Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-11-16T21:57:16Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4102

AutorestCI · 2018-11-16T21:57:33Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

azuresdkci · 2018-11-16T22:01:03Z

Can one of the admins verify this patch?

salameer · 2018-11-19T22:36:56Z

reassinging since @sarangan12 is oof

@rifrankl please fix the validation errors. you can check them through the OpenAPI Hub here

...fication/imds/resource-manager/Microsoft.InstanceMetadataService/stable/2018-10-01/imds.json

amarzavery · 2018-11-20T21:30:26Z

Please add language specific reademe..md files for go, nodejs, ruby, typescript, python.

Take a look at this example.

amarzavery · 2018-11-20T22:11:57Z

@rifrankl -

What do you mean by initial commit? Is the service already deployed? If it is not yet deployed then is there any ETA? We cannot merge the PR to master if the service is not deployed to Prod.
If it will take multiple revisions for this swagger to become stable and that would also involve service api changes, then we would recommend creating a feature branch. PRs can be merged into this feature branch and once you are stable/comfortable then a final PR can be made to master from the feature branch. Please go over here to create a feature branch.
- If required, the feature branch can be white listed, so that they can be assigned reviewers from our side.
Was this approved by ARM team? If not then you need to get this approved from ARM first and make sure you fix all the ARM linter errors.

-Removed erroneous format tags -Added security section

-Moved to imds/data-plane from imds/resource-provider

specification/imds/data-plane/Microsoft.InstanceMetadataService/stable/2018-10-01/imds.json

-Removed individual error codes from operations

specification/imds/data-plane/Microsoft.InstanceMetadataService/stable/2018-10-01/imds.json

...data-plane/Microsoft.InstanceMetadataService/stable/2018-10-01/examples/getattesteddata.json

specification/imds/data-plane/Microsoft.InstanceMetadataService/stable/2018-10-01/imds.json

-Created separate Identity error property -Updated descriptions and added them where necessary -Created parameters section and moved api-version and Metadata to it -Renamed operationIds

specification/imds/data-plane/Microsoft.InstanceMetadataService/stable/2018-10-01/imds.json

-Removed previous API versions from enum

specification/imds/data-plane/Microsoft.InstanceMetadataService/stable/2018-10-01/imds.json

rifrankl · 2018-12-17T23:43:36Z

The remaining errors are errors for which we would like an exception. See email thread from 11/20

specification/imds/data-plane/readme.md

* Instance Metadata Service: Initial Commit Initial commit of Instance Metadata Service -Added Swagger for 2018-10-01 -Added examples for 2018-10-01 * Instance Metadata Service: Updates -Removed erroneous format tags -Added security section * Instance Metadata Service: Updates -Moved to imds/data-plane from imds/resource-provider * Instance Metadata Service: Added language .md files * Instance Metadata Service: Updated ErrorResponse -Removed individual error codes from operations * Instance Metadata Service: Updates to Swagger -Created separate Identity error property -Updated descriptions and added them where necessary -Created parameters section and moved api-version and Metadata to it -Renamed operationIds * Added x-ms-parameter-location to Metadata parameter * -Minor property name changes -Removed previous API versions from enum * -Fixed a typo * -Added missing descriptions * -Added more missing descriptions * -Changed openapi type to data-plane * -Added DefinitionsPropertiesNamesCamelCase suppression to readme * -Forgot one camelcase suppression * -Removed a newline

Instance Metadata Service: Initial Commit

f891877

Initial commit of Instance Metadata Service -Added Swagger for 2018-10-01 -Added examples for 2018-10-01

azuresdkci assigned sarangan12 Nov 16, 2018

azuresdkci requested a review from sarangan12 November 16, 2018 21:57

AutorestCI mentioned this pull request Nov 16, 2018

[AutoPR imds/resource-manager] Instance Metadata Service: Initial Commit Azure/azure-sdk-for-python#3809

Closed

salameer unassigned sarangan12 Nov 19, 2018

salameer added the Reassign label Nov 19, 2018

azuresdkci removed the Reassign label Nov 19, 2018

azuresdkci assigned amarzavery Nov 19, 2018

azuresdkci requested a review from amarzavery November 19, 2018 23:03

ravbhatnagar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 20, 2018

amarzavery suggested changes Nov 20, 2018

View reviewed changes

...fication/imds/resource-manager/Microsoft.InstanceMetadataService/stable/2018-10-01/imds.json Outdated Show resolved Hide resolved

...fication/imds/resource-manager/Microsoft.InstanceMetadataService/stable/2018-10-01/imds.json Show resolved Hide resolved

KrisBash added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 26, 2018

rifrankl added 2 commits November 26, 2018 13:45

Instance Metadata Service: Updates

492796f

-Removed erroneous format tags -Added security section

Instance Metadata Service: Updates

5ed5488

-Moved to imds/data-plane from imds/resource-provider

AutorestCI mentioned this pull request Nov 26, 2018

[AutoPR imds/data-plane] Instance Metadata Service: Initial Commit Azure/azure-sdk-for-python#3876

Merged

Instance Metadata Service: Added language .md files

8a09dad

amarzavery reviewed Nov 26, 2018

View reviewed changes

specification/imds/data-plane/Microsoft.InstanceMetadataService/stable/2018-10-01/imds.json Show resolved Hide resolved

amarzavery reviewed Nov 26, 2018

View reviewed changes

specification/imds/data-plane/Microsoft.InstanceMetadataService/stable/2018-10-01/imds.json Outdated Show resolved Hide resolved

amarzavery reviewed Nov 26, 2018

View reviewed changes

specification/imds/data-plane/Microsoft.InstanceMetadataService/stable/2018-10-01/imds.json Show resolved Hide resolved

Instance Metadata Service: Updated ErrorResponse

0773756

-Removed individual error codes from operations

amarzavery suggested changes Nov 26, 2018

View reviewed changes

amarzavery removed the ARMChangesRequested label Nov 26, 2018

amarzavery reviewed Nov 26, 2018

View reviewed changes

specification/imds/data-plane/Microsoft.InstanceMetadataService/stable/2018-10-01/imds.json Outdated Show resolved Hide resolved

rifrankl added 2 commits November 29, 2018 11:52

Instance Metadata Service: Updates to Swagger

cba3965

-Created separate Identity error property -Updated descriptions and added them where necessary -Created parameters section and moved api-version and Metadata to it -Renamed operationIds

Added x-ms-parameter-location to Metadata parameter

630659c

amarzavery reviewed Dec 6, 2018

View reviewed changes

specification/imds/data-plane/Microsoft.InstanceMetadataService/stable/2018-10-01/imds.json Outdated Show resolved Hide resolved

amarzavery reviewed Dec 6, 2018

View reviewed changes

specification/imds/data-plane/Microsoft.InstanceMetadataService/stable/2018-10-01/imds.json Outdated Show resolved Hide resolved

amarzavery reviewed Dec 6, 2018

View reviewed changes

specification/imds/data-plane/Microsoft.InstanceMetadataService/stable/2018-10-01/imds.json Show resolved Hide resolved

amarzavery reviewed Dec 6, 2018

View reviewed changes

specification/imds/data-plane/Microsoft.InstanceMetadataService/stable/2018-10-01/imds.json Outdated Show resolved Hide resolved

amarzavery reviewed Dec 6, 2018

View reviewed changes

specification/imds/data-plane/Microsoft.InstanceMetadataService/stable/2018-10-01/imds.json Show resolved Hide resolved

-Minor property name changes

5873893

-Removed previous API versions from enum

nschonni reviewed Dec 14, 2018

View reviewed changes

specification/imds/data-plane/Microsoft.InstanceMetadataService/stable/2018-10-01/imds.json Outdated Show resolved Hide resolved

rifrankl added 3 commits December 14, 2018 15:28

-Fixed a typo

54d9e43

-Added missing descriptions

2ae5a32

-Added more missing descriptions

2906407

rifrankl added 3 commits December 19, 2018 17:58

-Changed openapi type to data-plane

723f423

-Added DefinitionsPropertiesNamesCamelCase suppression to readme

617b32a

-Forgot one camelcase suppression

4e92a02

amarzavery reviewed Dec 19, 2018

View reviewed changes

specification/imds/data-plane/readme.md Outdated Show resolved Hide resolved

-Removed a newline

5887517

amarzavery approved these changes Dec 19, 2018

View reviewed changes

amarzavery merged commit 7119de0 into Azure:master Dec 19, 2018

Comments

Conversation

rifrankl commented Nov 16, 2018

Latest improvements:

Contribution checklist:

Uh oh!

openapi-portal-comment bot commented Nov 16, 2018

Uh oh!

AutorestCI commented Nov 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

AutorestCI commented Nov 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Nov 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Nov 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Nov 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Nov 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

azuresdkci commented Nov 16, 2018

Uh oh!

salameer commented Nov 19, 2018

Uh oh!

Uh oh!

Uh oh!

amarzavery commented Nov 20, 2018

Uh oh!

amarzavery commented Nov 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rifrankl commented Dec 17, 2018

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

AutorestCI commented Nov 16, 2018 •

edited

Loading

AutorestCI commented Nov 16, 2018 •

edited

Loading

AutorestCI commented Nov 16, 2018 •

edited

Loading

AutorestCI commented Nov 16, 2018 •

edited

Loading

AutorestCI commented Nov 16, 2018 •

edited

Loading

AutorestCI commented Nov 16, 2018 •

edited

Loading

amarzavery commented Nov 20, 2018 •

edited

Loading