[v2] fix: set NDEBUG=1 preprocessor flag in release mode

[tomekzaw]

What

This PR fixes the following error reported in #2265 that occurs when trying to build a RN app with Reanimated 3.6.x and RNVisionCamera 2.16.5 with Frame Processors enabled in release mode on iOS on Paper:

Undefined symbols for architecture x86_64:
  "reanimated::getCallGuard(facebook::jsi::Runtime&)", referenced from:
      void reanimated::WorkletRuntime::runGuarded<facebook::jsi::Object&>(std::__1::shared_ptr<reanimated::ShareableWorklet> const&, facebook::jsi::Object&) const in libVisionCamera.a(FrameProcessorRuntimeManager.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

The root cause of this issue is that Reanimated 3.6.0 uses a well-known NDEBUG flag but unfortunately React Native does not set it on iOS on Paper (it is set correctly on Fabric, though). The workaround is to set environmental variable PRODUCTION=1 when running pod install (so that RNReanimated.podspec knows that it should inject NDEBUG flag) but this flag is not well-documented so many people don't know about it.

Changes

• Added NDEBUG=1 flag to GCC_PREPROCESSOR_DEFINITIONS for Release variant in VisionCamera.podspec

Tested on

I reproduced the error on a fresh RN 0.72.7 app with Reanimated 3.6.0 and RNVisionCamera 2.16.5 on iOS in release mode. Then I made the change in VisionCamera's podspec and the error was gone.

Related issues

Fixes #2265.

See software-mansion/react-native-reanimated#5366 for full explanation.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-native-vision-camera	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 8, 2023 9:08pm

[mrousavy]

You're the 🐐! LGTM thanks Tomasz! ❤️

[tomekzaw]

@mrousavy Thanks for merging this PR! Would it be possible to publish a new v2 release with this fix?

[mrousavy]

Sorry, went for lunch & forgot haha - just released 2.16.5! :)

thanks again!

[tomekzaw]

Thank you on behalf of the entire community!