Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mrdoob the supposedly minor cleanup on #13543 forces the end user to work in a way that IMHO disrupts how a mathematically inclined person thinks about functions. A parametrization function returns the coordinates corresponding to the input parameters: it doesn't modify the parameters. I should think someone using ParametricGeometry would expect a function to behave like a mathematical function.
With the cleanup reversed, the end user still has the option to modify a third argument if desired for efficiency, but doesn't force that person to think non-mathematically. I would really like to know whether or not this cleanup was strictly necessary from a performance point of view.