ParametricGeometry Example: Clean up #13543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
Mar 9, 2018
|
Thanks! |
|
@nowherenearithaca Sorry. Overlooked updating the docs in this case. Would you like to contribute a patch to the docs? Did you at least get a console warning? |
|
No console warning - and adding one might be hard on performance because it's generally running a tight loop on that... which probably motivated the previous change there to begin with. I think you would have heard a lot of noise if this broke things for many people... |
|
Since no one has updated the documentation yet, here it is #13846. Does this change really improve performance enough to warrant breaking things? Certainly just cost me some time figuring out what was going on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minor cleanup