Remove optionalTarget: More clean up #13530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
commented
Mar 8, 2018
src/objects/Mesh.js
Outdated
| intersection.face = new Face3( a, b, c, Triangle.normal( vA, vB, vC ) ); | ||
| var face = new Face3( a, b, c ); | ||
|
|
||
| triangle.set( vA, vB, vC ).normal( faceNormal ); |
There was a problem hiding this comment.
@WestLangley In context of BufferGeometry.center(), the semantics of Triangle.normal() is also problematic. It should be Triangle.getNormal(), right?
There was a problem hiding this comment.
Yes, I guess it should be Triangle.getNormal( a, b, c, target ) and Triangle.prototype.getNormal( a, b, c, target ).
Also barycoordFromPoint() -> getBarycoord().
Separate PR, though.
WestLangley
reviewed
Mar 8, 2018
src/objects/Mesh.js
Outdated
| var face = new Face3( a, b, c ); | ||
|
|
||
| triangle.set( vA, vB, vC ).normal( faceNormal ); | ||
| face.normal.copy( faceNormal ); |
There was a problem hiding this comment.
In any event, you can write your existing code like so:
triangle.set( vA, vB, vC ).normal( face.normal );Or, better yet:
Triangle.normal( vA, vB, vC, face.normal );
|
Thanks! |
|
I've checked all examples, the editor and the docs and found no more warnings so far 👍 |
|
Thanks, @Mugen87 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #13522