Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove optionalTarget - part 4 #13518

Merged
merged 1 commit into from
Mar 7, 2018
Merged

Remove optionalTarget - part 4 #13518

merged 1 commit into from
Mar 7, 2018

Conversation

WestLangley
Copy link
Collaborator

As proposed in #12231.

@mrdoob mrdoob added this to the r91 milestone Mar 7, 2018
@mrdoob mrdoob merged commit 14e0532 into mrdoob:dev Mar 7, 2018
@mrdoob
Copy link
Owner

mrdoob commented Mar 7, 2018

Thanks thanks!

@WestLangley WestLangley deleted the dev-optTgt_4 branch March 7, 2018 21:09

if ( target === undefined ) {

console.warn( 'THREE.Ray: .closestPointToPoint() target is now required' );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WestLangley

This triggers in the Points.raycast() testpoint function.

(I haven't looked at other objects raycast methods)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #13530

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aardgoose Trying to track these down...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants