Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLTFExporter: Add forcePOT option on the example #13426

Merged
merged 3 commits into from
Feb 25, 2018
Merged

Conversation

fernandojsg
Copy link
Collaborator

Just adding the option that @takahirox implemented on #13424 to the example

@@ -35,6 +35,7 @@
<label><input id="option_drawrange" name="visible" type="checkbox" checked="checked"/>Truncate drawRange</label>
<label><input id="option_binary" name="visible" type="checkbox">Binary (<code>.glb</code>)</label>
<label><input id="option_forceindices" name="visible" type="checkbox">Force indices</label>
<label><input id="option_forcepot" name="visible" type="checkbox">Force PTO textures</label>
Copy link
Owner

@mrdoob mrdoob Feb 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Force PTO 😊

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrdoob Done! Force PTO is what I need :_D

@fernandojsg
Copy link
Collaborator Author

I've just added a small fix to the example by changing the near value for the ortho camera to be >0 as discussed on #13429

@takahirox
Copy link
Collaborator

A bit off topic, feeling like we should rename forcePowerOfTwoTexture with forcePowerOfTwoTextures (adding 's').

@fernandojsg
Copy link
Collaborator Author

@takahirox yeah good point 👍 just changed it too

@mrdoob mrdoob added this to the r91 milestone Feb 25, 2018
@mrdoob mrdoob merged commit 6ad3ae6 into mrdoob:dev Feb 25, 2018
@mrdoob
Copy link
Owner

mrdoob commented Feb 25, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants