GLTFExporter: Add forcePowerOfTwoTexture option #13424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Repository owner
deleted a comment from
takahirox
Feb 24, 2018
mrdoob
reviewed
Feb 24, 2018
| @@ -459,21 +473,36 @@ THREE.GLTFExporter.prototype = { | |||
| var mimeType = map.format === THREE.RGBAFormat ? 'image/png' : 'image/jpeg'; | |||
| var gltfImage = { mimeType: mimeType }; | |||
|
|
|||
| if ( options.embedImages ) { | |||
| if ( options.embedImages || ( options.forcePowerOfTwoTexture && ! isPowerOfTwo( map.image ) ) ) { | |||
There was a problem hiding this comment.
How about this instead?
if ( options.embedImages ) {
var canvas = cachedCanvas = cachedCanvas || document.createElement( 'canvas' );
canvas.width = map.image.width;
canvas.height = map.image.height;
if ( options.forcePowerOfTwoTexture && ! isPowerOfTwo( map.image ) ) {
console.warn( 'GLTFExporter: image is not power of two. Resized and embedded.', image );
canvas.width = THREE.Math.floorPowerOfTwo( canvas.width );
canvas.height = THREE.Math.floorPowerOfTwo( canvas.height );
}There was a problem hiding this comment.
So, you meant you wanna POT conversion only if options.embedImages is true?
There was a problem hiding this comment.
OK, I've updated. We might need to make clear that .forcePowerOfTwoTexture option works only if .embedImages is true by renaming the option or adding note to doc. Let's do that in another PR if necessary (sorry time to sleep here now!).
|
Uh? I didn't. I deleted my own comments... |
Haha, ok I believe in you. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13397 (comment)
This PR adds
forcePowerOfTwoTextureoption toGLTFExporter.