GLTFLoader: Support morph targetNames #13367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
reviewed
Feb 19, 2018
examples/js/loaders/GLTFLoader.js
Outdated
| @@ -1205,6 +1205,17 @@ THREE.GLTFLoader = ( function () { | |||
|
|
|||
| } | |||
|
|
|||
| // .extras has user defined data so just in case cheking if .extras.targetNames is array. | |||
There was a problem hiding this comment.
minor: would say .extras has user-defined data, so check that .extras.targetNames is an array.
There was a problem hiding this comment.
Updated. Thanks for always correcting my English!
donmccurdy
approved these changes
Feb 20, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blender and
GLTFExporterstore morph target names into mesh.extra as suggested in glTF spec issue thread. It isn't glTF core spec yet but I wanna enableGLTFLoaderto load it.#13366
KhronosGroup/glTF-Blender-Exporter#153
KhronosGroup/glTF#1036